fix: prevent catalogs using the workspace:, link:, and file: protocols#8255
Merged
fix: prevent catalogs using the workspace:, link:, and file: protocols#8255
workspace:, link:, and file: protocols#8255Conversation
zkochan
approved these changes
Jun 28, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Using pnpm catalogs with the
workspace:,link:, andfile:protocols "kind of works in the beta release today". However, I think there's surprising behavior in each.workspace:protocol, it's kind of weird to see theworkspace:*protocol defined in catalogs in the first place. I can't think of a good reason for this indirection. I think spending time trying to support this isn't a good use of developer time.link:andfile:protocols are often used to refer to relative paths. Since pnpm catalogs are defined inpnpm-workspace.yaml, I think most users will expect paths to be relative to that file. Unfortunately they're relative to the project'spackage.json, which doesn't feel right. Let's disable this until we have time to better support it in a future pnpm release.