fix: update WorkspaceManifest packages field type to be non-null#8205
Merged
fix: update WorkspaceManifest packages field type to be non-null#8205
Conversation
zkochan
approved these changes
Jun 14, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
The
packagesfield ofWorkspaceManifestis currently defined as nullable, but I believe this won't ever be the case since we're verifying that it's always present inreadWorkspaceManifest.pnpm/workspace/read-manifest/test/index.ts
Lines 24 to 28 in 6ccdfff
Let's remove the nullable type annotation to make it easier for code using
WorkspaceManifestto readpackages.Motivation
This will be useful for #8120 (comment).
It'd be good to use the compiler to rely on
patternsnever beingundefined, which would be the case ifpackagesfromWorkspaceManifestalso can't beundefined.