Skip to content

fix: don't fail if the pnpm version doesn't match the one in the packageManager field#8166

Merged
zkochan merged 3 commits intomainfrom
no-strict
Jun 5, 2024
Merged

fix: don't fail if the pnpm version doesn't match the one in the packageManager field#8166
zkochan merged 3 commits intomainfrom
no-strict

Conversation

@zkochan
Copy link
Copy Markdown
Member

@zkochan zkochan commented Jun 4, 2024

close #8087

I considered printing a warning or info message instead. However, this would get printed on all commands and probably break some tools that parse the output of pnpm. So, safer just to not print anything (and faster to implement).

@FleetAdmiralJakob
Copy link
Copy Markdown

But with this change I can still fix the package manager version with .npmrc right?

@zkochan
Copy link
Copy Markdown
Member Author

zkochan commented Jun 4, 2024

I can still fix the package manager version with .npmrc right?

I don't understand. There will be no error, so what do you want to fix? The error will only happen if the package manager names will not much. In that case, yes, you'll be able to make that error go away with a setting in .npmrc.

@FleetAdmiralJakob
Copy link
Copy Markdown

I want the error and asked if that possible to get the error back with the .npmrc

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

package-manager-strict enforcement in pnpm 9 is a massive headache

2 participants