feat: add lockfile-include-tarball-url option#5054
Conversation
|
💖 Thanks for opening this pull request! 💖 |
|
I had a trouble running tests using So if anyone could guide me on this I would be grateful. |
that command should run the registry. Try again. The setting name is not very good. I'd probably call it something like Add a test and a changeset. |
The registry is set up, but there are no is-positive and is-negative packages there, thus 404. I couldn't find a fix, so I will rely on CI tests. As requested, I added a test and a changeset and I changed option name to the one suggested. New test passed locally. I hope it is OK. Also, FYI for each git push I got the error below, so I had to push with --no-verify, because this is not related to my change. |
Did you run |
Yes, I did. |
- add save-tarball-url option, which saves resolved tarball URL to pnpm-lock.yaml during install or add command
- remove help section for new option
…dd test - option is now named lockfile-include-tarball-url as suggested by @zkochan - add test covering new feature
- add changeset
7da48d5 to
4f854ee
Compare
lockfile-include-tarball-url option
|
Thanks for the last commit :) So, I guess now I just wait for your approval and merge. |
|
Congrats on merging your first pull request! 🎉🎉🎉 |
|
Wow, I didn't expect it will be so quick :D Thanks a lot! |
In this PR I add
lockfile-include-tarball-urloption, which when set to true on npm env, makes the installation process of new packages add their resolved tarball URL to pnpm-lock.yamlI need a way to save a registry from which each package was fetched in pnpm-lock.yaml.
In my company we have 2 registries - one with officially approved packages, the other one mirroring the public npm registry, for development purposes.
I want to keep the information which registry was used for a given package in pnpm-lock.yaml, so that during PR review we know, if there was a package fetched from unofficial registry and it should be first approved.
I see that sometimes the tarball URL is saved, but only if the url is non-standard.
For my case it's really helpful to keep that information for each package.