Skip to content

feat(file-reporter): remove file reporter#5012

Merged
zkochan merged 4 commits into
pnpm:mainfrom
william2958:fix/4949-remove
Jul 11, 2022
Merged

feat(file-reporter): remove file reporter#5012
zkochan merged 4 commits into
pnpm:mainfrom
william2958:fix/4949-remove

Conversation

@william2958

Copy link
Copy Markdown
Contributor

Resolves issue #4949 where pnpm install will crash in a very large repository as the logs object in memory becomes too large for JSON.stringify to handle.

Comment thread pnpm-lock.yaml Outdated
patchedDependencies:
pkg@5.7.0:
hash: pp6fkuhwkrqq7cjcj7uqpf37e4
path: patches/pkg@5.7.0.patch

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do you use the latest pnpm? The lockfile doesn't look right

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems I was using a previous version of pnpm to install (7.1.7) but after upgrading to the latest version (7.5.0) & rerunning pnpm install, the pnpm-lock.yaml file is unchanged - is there something else I missed?

Comment thread .changeset/rare-walls-smell.md Outdated
Comment thread .changeset/rare-walls-smell.md Outdated
william2958 and others added 2 commits July 11, 2022 18:34
Co-authored-by: Zoltan Kochan <z@kochan.io>
Co-authored-by: Zoltan Kochan <z@kochan.io>
@zkochan zkochan enabled auto-merge (squash) July 11, 2022 22:44
@zkochan zkochan disabled auto-merge July 11, 2022 23:40
@zkochan zkochan merged commit c0b36bf into pnpm:main Jul 11, 2022
@welcome

welcome Bot commented Jul 11, 2022

Copy link
Copy Markdown

Congrats on merging your first pull request! 🎉🎉🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants