Skip to content

feat: use irreversible-delete in pnpm patch-commit#5008

Merged
zkochan merged 1 commit into
pnpm:mainfrom
webstrand:irreversible-delete
Jul 11, 2022
Merged

feat: use irreversible-delete in pnpm patch-commit#5008
zkochan merged 1 commit into
pnpm:mainfrom
webstrand:irreversible-delete

Conversation

@webstrand

Copy link
Copy Markdown
Contributor

Avoid retaining a copy of the contents of files deleted during patching

fixes #5003

@webstrand webstrand requested a review from zkochan as a code owner July 11, 2022 14:33
@welcome

welcome Bot commented Jul 11, 2022

Copy link
Copy Markdown

💖 Thanks for opening this pull request! 💖
Please be patient and we will get back to you as soon as we can.

Avoid retaining a copy of the contents of files deleted during patching
@webstrand webstrand force-pushed the irreversible-delete branch from 4eed4d0 to e100086 Compare July 11, 2022 16:22
@webstrand

Copy link
Copy Markdown
Contributor Author

fixed the issue of fs.rmSync not being available in Node.js v16.x, replaced it with fs.unlink

@zkochan zkochan merged commit f0cd8b0 into pnpm:main Jul 11, 2022
@welcome

welcome Bot commented Jul 11, 2022

Copy link
Copy Markdown

Congrats on merging your first pull request! 🎉🎉🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add --irreversible-delete to git diff in patch-commit

2 participants