Add "refs/"+refname to resolution options#4953
Merged
Conversation
|
💖 Thanks for opening this pull request! 💖 |
Member
|
We need a test for this. And also changesets. |
Previously, if you wanted to check out a git PR branch, you needed to specify the url as: `github:pnpm/pnpm#refs/pull/123/merge`. Now this will resolve without the leading "refs": `github:pnpm/pnpm#pull/123/merge` Fix #2045
Contributor
Author
@zkochan Done. |
zkochan
approved these changes
Jun 29, 2022
|
Congrats on merging your first pull request! 🎉🎉🎉 |
This was referenced Jun 30, 2022
This was referenced Aug 8, 2022
This was referenced Aug 16, 2022
This was referenced Aug 25, 2022
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #2045
Previously, if you wanted to check out a git PR branch, you needed to specify the url as, e.g.
github:pnpm/pnpm#refs/pull/4953/merge. Now this will resolve without the leading "refs", i.e.github:pnpm/pnpm#pull/4953/merge