Skip to content

fix: don't fail when the patched pkg appears multiple times#4945

Merged
zkochan merged 3 commits into
mainfrom
fix/4938
Jun 27, 2022
Merged

fix: don't fail when the patched pkg appears multiple times#4945
zkochan merged 3 commits into
mainfrom
fix/4938

Conversation

@zkochan

@zkochan zkochan commented Jun 27, 2022

Copy link
Copy Markdown
Member

Don't fail when the patched package appears multiple times in the dependency graph

close #4938

Don't fail when the patched package appears multiple times in the dependency graph

close #4938
@zkochan zkochan added this to the v7.4 milestone Jun 27, 2022
@zkochan zkochan merged commit fc581d3 into main Jun 27, 2022
@zkochan zkochan deleted the fix/4938 branch June 27, 2022 23:23
@Jack-Works

Copy link
Copy Markdown
Member

Thanks!! It's a quick fix!

@zkochan

zkochan commented Jun 28, 2022

Copy link
Copy Markdown
Member Author

Does patching work now? can I release 7.4?

@Jack-Works

Copy link
Copy Markdown
Member

It works on my side! There is still a small problem with the patch-commit but it doesn't block me from using it.

When I commit a patch, it might run into "cannot apply a patch to [some other patched packages]", but if I run pnpm install again, it works well.

Thanks for your work!! This feature is really useful!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Cannot read properties of undefined (reading 'depth')

2 participants