fix: use recursive for deploy command directory creation#4943
Conversation
|
💖 Thanks for opening this pull request! 💖 |
zkochan
approved these changes
Jun 27, 2022
Member
|
Add a changeset |
|
Congrats on merging your first pull request! 🎉🎉🎉 |
This was referenced Jun 28, 2022
This was referenced Jul 31, 2022
This was referenced Aug 8, 2022
This was referenced Aug 16, 2022
This was referenced Aug 25, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently the deploy command will throw when the deploy directory is nested.
Example running:
pnpm --filter=pkg deploy deploy/pkgwill throw with
ENOENT ENOENT: no such file or directory, mkdir '/home/project/deploy/pkg'This happens when the parent folder (deploy in this case) has not been already created.
This PR adds { recursive: true } to allow creating the deploy directory recursivly.