feat(env): install Node.js using a version range#3629
Merged
Conversation
7c84104 to
52557f2
Compare
juanpicado
reviewed
Jul 30, 2021
| expect(stdout.toString()).toBe('v6.17.1') | ||
|
|
||
| const dirs = fs.readdirSync(path.resolve('nodejs')) | ||
| expect(dirs).toEqual(['6.17.1']) |
Member
There was a problem hiding this comment.
could users download any Node.js version?
Member
Author
There was a problem hiding this comment.
Any of those that are in this index: https://nodejs.org/download/release/index.json
Member
There was a problem hiding this comment.
I see, the point is being able to download any Node.js version #3434 but the bundle one is something already predefined in build time.
Member
Author
There was a problem hiding this comment.
Yes, the bundled one is static. The bundled one is only used to run the pnpm CLI
Member
|
@zkochan what's the command to test it? |
Member
Author
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.