Skip to content

feat: hoisting by pattern#1997

Merged
zkochan merged 17 commits intomasterfrom
feat/1938
Sep 8, 2019
Merged

feat: hoisting by pattern#1997
zkochan merged 17 commits intomasterfrom
feat/1938

Conversation

@zkochan
Copy link
Member

@zkochan zkochan commented Sep 4, 2019 •
edited
Loading

close #1938

  • hoist should fail when used with --independent-leaves
  • update reporting of ERR_PNPM_SHAMEFULLY_FLATTEN_NOT_IN_LOCKFILE_DIR
  • verify that prune works with hoisted deps that are in .pnpm/node_modules
  • test that node_modules/.pnpm/node_modules/.bin is added to PATH
  • in a monorepo, the deps of all workspace packages should be hoisted
  • cover with tests hoisting in monorepo
  • test the warning about --shamefully-flatten in @pnpm/config
  • global install should always use hoisting

@zkochan zkochan mentioned this pull request Sep 4, 2019
Closed
@KSXGitHub
Copy link
Contributor

KSXGitHub commented Sep 5, 2019

close #1938

Wait, how does this close #1938? The issue only concern is flag naming, not some new feature.

@zkochan
Copy link
Member Author

zkochan commented Sep 5, 2019

That flag will be deprecated. If you'll need to hoist everything, you'll have to use hoist=* instead of shamefully-flatten=true

@zkochan zkochan mentioned this pull request Sep 7, 2019
Closed
7 tasks
@zkochan zkochan mentioned this pull request Sep 7, 2019
Closed
@zkochan zkochan added this to the v4.0 milestone Sep 8, 2019
@zkochan
refactor: -SHAMEFULLY_FLATTEN_NOT_IN_LOCKFILE_DIR
3d83f58 
Remove ERR_PNPM_SHAMEFULLY_FLATTEN_NOT_IN_LOCKFILE_DIR
@zkochan zkochan merged commit 3a9fdd8 into master Sep 8, 2019
@zkochan zkochan deleted the feat/1938 branch September 8, 2019 17:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

type: breaking change

Projects

None yet

Milestone

v4.0

Development

Successfully merging this pull request may close these issues.

"shamefully-flatten" is long and not intuitive, consider "flatten" instead

2 participants

@zkochan @KSXGitHub