Walkthrough

Two if: github.repository == 'pnpm/pnpm' conditions are added to .github/workflows/ecosystem-e2e.yml: one on the build job and one on the ecosystem-e2e matrix job, preventing both from running on fork repositories.

Changes

Ecosystem E2E Workflow Fork Guard

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Assessment against linked issues

Assessment against linked issues: Out-of-scope changes

• X
• Mastodon
• Reddit
• LinkedIn

• Gate Ecosystem E2E build job to run only in pnpm/pnpm repository.
• Gate Ecosystem E2E matrix job to run only in pnpm/pnpm repository.
• Prevent scheduled workflow failures and resulting error emails on forks.

graph TD
  A["GitHub Actions trigger"] --> B{"Main repo?"} --> C["E2E Build job"] --> D["E2E Matrix job"]
  B --> E["Skip jobs"]

Loading

The following are alternative approaches to this PR:

1. Gate only scheduled runs

• ➕ Still allows ad-hoc/manual runs on forks if desired
• ➕ More targeted to the reported failure mode (schedule on forks)
• ➖ Slightly more complex condition logic (event-name branching)
• ➖ Still permits other fork-triggered runs to consume CI resources

2. Use org/owner check instead of full repo slug

• ➕ More resilient if the repository is renamed or moved within the org
• ➕ Shorter condition (e.g., github.repository_owner == 'pnpm')
• ➖ Potentially broader than intended if other repos in the org should not run this workflow
• ➖ Less explicit than checking the canonical repo full name

Recommendation: The current approach (job-level if: github.repository == 'pnpm/pnpm') is the simplest and most explicit way to prevent fork executions (including scheduled runs) without impacting runs in the canonical repository. Consider gating only schedule if you explicitly want forks to be able to run these jobs manually.

Other (1) +2 / -0

ecosystem-e2e.ymlSkip Ecosystem E2E jobs when running in forks +2/-0

Skip Ecosystem E2E jobs when running in forks

• Adds a repository guard to both the build job and the ecosystem-e2e matrix job. This prevents the workflow from executing on forked repositories, avoiding scheduled-run failures and associated error emails.

.github/workflows/ecosystem-e2e.yml

Description

The new job-level condition if: github.repository == 'pnpm/pnpm' disables both schedule and
workflow_dispatch runs on forks, so fork owners can’t manually run Ecosystem E2E in their own repo
anymore. This is broader than the stated goal (stop scheduled fork failures) and may remove a useful
debugging/testing path for fork maintainers.

Code

.github/workflows/ecosystem-e2e.yml[28]

+    if: github.repository == 'pnpm/pnpm' # Only run on the main repository, not forks

Evidence

The workflow is triggered by both workflow_dispatch and schedule, but the new job-level if
gates execution solely on the repository name, which evaluates false on forks for both triggers.

.github/workflows/ecosystem-e2e.yml[14-18]
.github/workflows/ecosystem-e2e.yml[27-66]

Agent prompt

The issue below was found during a code review. Follow the provided context and guidance below and implement a solution

## Issue description
The workflow currently skips jobs on forks for *all* triggers, including `workflow_dispatch`.
### Issue Context
The stated intent is to stop scheduled runs on forks, but the workflow also supports manual runs (`workflow_dispatch`).
### Fix
Adjust the job `if:` to only block scheduled runs on forks, e.g.:
- `if: github.event_name != 'schedule' || github.repository == 'pnpm/pnpm'`
### Fix Focus Areas
- .github/workflows/ecosystem-e2e.yml[14-18]
- .github/workflows/ecosystem-e2e.yml[27-66]

ⓘ Copy this prompt and use it to remediate the issue with your preferred AI generation tools

🐞 Bugs (1) 📘 Rule violations (0) 📜 Skill insights (0)