Walkthrough

The pacquet-ci.yml workflow drops path-based trigger filters and instead introduces a dedicated changes job using dorny/paths-filter to detect Rust file modifications. All downstream CI jobs (test, clippy, doc, typos, deny, format, dylint) are gated behind the resulting rust output, with dylint additionally handling change-detection failure via an early-exit step.

Changes

Path-filtered CI gating for Rust jobs

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Poem

🐇 Hoppity-hop through the CI lane,
No more running when nothing's changed!
A rust flag flips, the jobs stand by,
Only real diffs let the workflows fly.
The bunny saves cycles — oh my, oh my! 🌿

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

• X
• Mastodon
• Reddit
• LinkedIn

Description

The new changes filter does not include .github/scripts/**, but the Rust test job executes
.github/scripts/measure-command.mjs; PRs changing only that script will run the workflow yet skip
all Rust jobs. This can let CI-critical script regressions merge without exercising the Rust
pipeline.

Code

.github/workflows/pacquet-ci.yml[R48-64]

+          filters: |
+            rust:
+              - 'pacquet/**'
+              - 'pnpr/**'
+              - 'Cargo.toml'
+              - 'Cargo.lock'
+              - 'rust-toolchain.toml'
+              - 'rustfmt.toml'
+              - 'deny.toml'
+              - 'dylint.toml'
+              - '.taplo.toml'
+              - '.typos.toml'
+              - 'justfile'
+              - '.cargo/**'
+              - '.github/actions/rustup/**'
+              - '.github/actions/binstall/**'
+              - '.github/workflows/pacquet-ci.yml'

Evidence

The changes job’s rust: filter list excludes .github/scripts/**, while the test job runs
node .github/scripts/measure-command.mjs and is gated on needs.changes.outputs.rust == 'true',
so script-only changes will skip Rust CI.

.github/workflows/pacquet-ci.yml[28-65]
.github/workflows/pacquet-ci.yml[66-70]
.github/workflows/pacquet-ci.yml[130-155]

Agent prompt

The issue below was found during a code review. Follow the provided context and guidance below and implement a solution

## Issue description
The new Rust change detector omits `.github/scripts/**`, but Rust CI jobs execute scripts from that directory. As a result, changes to those scripts can cause the workflow to run while skipping the Rust jobs, reducing coverage and potentially allowing CI breakage to merge.
### Issue Context
The `test` job runs `node .github/scripts/measure-command.mjs ...`, but `changes` only marks Rust CI relevant when files match the `rust:` filter list.
### Fix Focus Areas
- .github/workflows/pacquet-ci.yml[44-65]

ⓘ Copy this prompt and use it to remediate the issue with your preferred AI generation tools

Description

dylint is intended to run when changes fails (via needs.changes.result != 'success') and emit
an explicit error, but as a needs: changes dependent it may not get scheduled on changes failure
without an always()-style override. This undermines the stated goal of keeping the required Dylint
check reportable when change detection breaks.

Code

.github/workflows/pacquet-ci.yml[R310-318]

+    needs: changes
+    if: ${{ !cancelled() && (github.event_name == 'workflow_dispatch' || needs.changes.outputs.rust == 'true' || needs.changes.result != 'success') }}
 runs-on: ubuntu-latest
 steps:
+      - name: Verify change detection
+        if: ${{ needs.changes.result != 'success' }}
+        run: |
+          echo "::error::Unable to determine whether Rust CI should run."
+          exit 1

Evidence

The job-level if includes needs.changes.result != 'success' and the first step tries to error in
that case, but the job is still declared with needs: changes, so the error-reporting path is at
risk of being skipped when changes fails.

.github/workflows/pacquet-ci.yml[308-319]
.github/workflows/pacquet-ci.yml[28-65]

Agent prompt

The issue below was found during a code review. Follow the provided context and guidance below and implement a solution

## Issue description
The `dylint` job attempts to run when the `changes` job fails by checking `needs.changes.result != 'success'`, but because it depends on `changes`, it may be skipped on upstream failure unless the job-level condition explicitly opts into running after failures.
### Issue Context
The workflow adds a "Verify change detection" step that should fail the job when change detection is unavailable; ensure this step can run even when `changes` fails.
### Fix Focus Areas
- .github/workflows/pacquet-ci.yml[308-319]

ⓘ Copy this prompt and use it to remediate the issue with your preferred AI generation tools

• Remove workflow-level path filters so required checks are always created on PRs.
• Add a change-detection job to skip Rust CI jobs when Rust-relevant files didn’t change.
• Ensure manual dispatch always runs full Rust CI; fail Dylint if change detection fails.

The following are alternative approaches to this PR:

Recommendation: The chosen approach (remove workflow-level path filters and add an explicit change-detection job) is the best fit for the primary goal: required checks must always be created so they can report “skipped” vs never existing. The added guard in Dylint to fail when change detection fails is a good safety net; keep the filter list aligned with what the Rust jobs actually depend on to avoid false skips.

pacquet-ci.yml Move Rust relevance filtering into a changes job; keep required checks reportable +64/-35

Move Rust relevance filtering into a changes job; keep required checks reportable

• Removes workflow-level path filters for pull_request and push to ensure checks are always created. Adds a 'changes' job using 'dorny/paths-filter' (or a manual-dispatch override) and gates expensive Rust jobs on its output, while making Dylint run with 'always()' and explicitly fail if change detection cannot be computed.

.github/workflows/pacquet-ci.yml

---