chore: update lockfile, Node.js, pnpm, and pacquet versions#12261
Merged
Conversation
Review Summary by QodoUpdate Node.js runtime version specifier to caret range
WalkthroughsDescription• Updates Node.js runtime version specifier to caret range • Modifies pnpm lockfile to reflect version constraint changes • Ensures flexible Node.js version compatibility for runtime Diagramflowchart LR
A["package.json"] -- "Update node@runtime specifier" --> B["Caret range ^26.3.0"]
C["pnpm-lock.yaml"] -- "Sync lockfile" --> B
B -- "Allows patch updates" --> D["Flexible versioning"]
File Changes1. package.json
|
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (2)
📜 Recent review details⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (4)
🧰 Additional context used🧠 Learnings (1)📚 Learning: 2026-05-05T23:03:04.286ZApplied to files:
🔇 Additional comments (4)
📝 WalkthroughWalkthroughBumps the pinned pnpm version in root ChangesTooling version updates
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Possibly related PRs
Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@package.json`:
- Line 20: The regex in .meta-updater/src/index.ts function
syncNodeRuntimeInScripts currently only matches plain numeric versions for
node@runtime and thus misses strings like node@runtime:^26.3.0 used in the
package.json compile-only script; update the regex to accept common semver range
prefixes (e.g. ^, ~, >=, <=, >, <) before the version so node@runtime:^26.3.0
will match and be replaced, and ensure you update the pattern that targets the
compile-only script's node@runtime token accordingly; also verify separately
that pnx node@runtime supports semver ranges (if it does not, revert to pinning
and adjust the meta-updater behavior).
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro Plus
Run ID: c4cd66fc-c0c1-414f-972c-573c7d15865d
⛔ Files ignored due to path filters (1)
pnpm-lock.yamlis excluded by!**/pnpm-lock.yaml
📒 Files selected for processing (1)
package.json
📜 Review details
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (4)
- GitHub Check: Compile & Lint
- GitHub Check: Run benchmark on ubuntu-latest
- GitHub Check: Analyze (javascript)
- GitHub Check: Compile & Lint
🧰 Additional context used
🧠 Learnings (14)
📓 Common learnings
Learnt from: CR
Repo: pnpm/pnpm PR: 0
File: AGENTS.md:0-0
Timestamp: 2026-06-06T22:48:27.363Z
Learning: Keep pnpm and pacquet in sync — any user-visible change (CLI flags, defaults, environment-variable handling, lockfile/manifest/state-file format, error codes and messages, log emissions, store layout, hook semantics) must land in both the TypeScript pnpm CLI and the Rust pacquet port in the same PR
Learnt from: CR
Repo: pnpm/pnpm PR: 0
File: AGENTS.md:0-0
Timestamp: 2026-06-06T22:48:27.363Z
Learning: Always explicitly include `pnpm` in changesets with the appropriate version bump; the pnpm CLI only receives automatic patch bumps from dependencies, so minor or major bumps must be specified explicitly
Learnt from: CR
Repo: pnpm/pnpm PR: 0
File: pacquet/AGENTS.md:0-0
Timestamp: 2026-05-29T18:03:15.372Z
Learning: Reference the upstream pnpm commit/PR when porting code from pnpm in commit messages
Learnt from: CR
Repo: pnpm/pnpm PR: 0
File: pacquet/AGENTS.md:0-0
Timestamp: 2026-05-29T18:03:15.372Z
Learning: Do not change lockfile format, store layout, `.npmrc` semantics, or CLI surface unless pnpm changed them first
Learnt from: CR
Repo: pnpm/pnpm PR: 0
File: AGENTS.md:0-0
Timestamp: 2026-06-06T22:48:27.363Z
Learning: After changing any package, rebuild the bundle with `pnpm --filter pnpm run compile` (which runs tsgo --build, linting, and pnpm run bundle) before running e2e tests, as pnpm CLI e2e tests use the bundled pnpm/dist/pnpm.mjs
Learnt from: zkochan
Repo: pnpm/pnpm PR: 11479
File: __utils__/scripts/package.json:6-9
Timestamp: 2026-05-05T23:03:30.044Z
Learning: In the pnpm/pnpm repository, the pattern `cross-env NODE_OPTIONS="$NODE_OPTIONS ..." jest` is an intentional, established convention used across many package.json files (e.g., `fs/hard-link-dir`, `worker`, `__utils__/scripts`). Do not flag this as a cross-platform issue in individual files; any fix should be applied repo-wide as a separate change.
Learnt from: CR
Repo: pnpm/pnpm PR: 0
File: pacquet/AGENTS.md:0-0
Timestamp: 2026-05-29T18:03:15.372Z
Learning: Match how the same feature is implemented in the TypeScript pnpm CLI — any change in pacquet must match pnpm's behavior, logic, edge cases, config resolution, error messages, file/lockfile formats, and existing tests
Learnt from: zkochan
Repo: pnpm/pnpm PR: 11734
File: installing/deps-installer/src/install/runPacquet.ts:48-51
Timestamp: 2026-05-19T07:12:00.339Z
Learning: In pnpm/pnpm, `runPacquet.ts` spawns the pacquet bin via `spawn(process.execPath, [pacquetBin, ...args], ...)` rather than `spawn(pacquetBin, args, ...)`. This is intentional: `pacquetBin` (`node_modules/.pnpm-config/pacquet/bin/pacquet`) is a Node wrapper script (starts with `#!/usr/bin/env node`) that resolves the platform-specific native binary at runtime. Spawning it directly works on Unix via shebang but silently breaks on Windows where shebangs are not honoured; using `process.execPath` ensures the launcher runs under the same Node binary on every platform. Do not flag this as a bug.
📚 Learning: 2026-06-06T22:48:27.363Z
Learnt from: CR
Repo: pnpm/pnpm PR: 0
File: AGENTS.md:0-0
Timestamp: 2026-06-06T22:48:27.363Z
Learning: Always explicitly include `pnpm` in changesets with the appropriate version bump; the pnpm CLI only receives automatic patch bumps from dependencies, so minor or major bumps must be specified explicitly
Applied to files:
package.json
📚 Learning: 2026-06-06T22:48:27.363Z
Learnt from: CR
Repo: pnpm/pnpm PR: 0
File: AGENTS.md:0-0
Timestamp: 2026-06-06T22:48:27.363Z
Learning: Keep pnpm and pacquet in sync — any user-visible change (CLI flags, defaults, environment-variable handling, lockfile/manifest/state-file format, error codes and messages, log emissions, store layout, hook semantics) must land in both the TypeScript pnpm CLI and the Rust pacquet port in the same PR
Applied to files:
package.json
📚 Learning: 2026-06-06T22:48:27.363Z
Learnt from: CR
Repo: pnpm/pnpm PR: 0
File: AGENTS.md:0-0
Timestamp: 2026-06-06T22:48:27.363Z
Learning: After changing any package, rebuild the bundle with `pnpm --filter pnpm run compile` (which runs tsgo --build, linting, and pnpm run bundle) before running e2e tests, as pnpm CLI e2e tests use the bundled pnpm/dist/pnpm.mjs
Applied to files:
package.json
📚 Learning: 2026-05-29T18:03:15.372Z
Learnt from: CR
Repo: pnpm/pnpm PR: 0
File: pacquet/AGENTS.md:0-0
Timestamp: 2026-05-29T18:03:15.372Z
Learning: Do not change lockfile format, store layout, `.npmrc` semantics, or CLI surface unless pnpm changed them first
Applied to files:
package.json
📚 Learning: 2026-05-05T23:03:04.286Z
Learnt from: zkochan
Repo: pnpm/pnpm PR: 11479
File: __utils__/scripts/package.json:6-9
Timestamp: 2026-05-05T23:03:04.286Z
Learning: The pattern cross-env NODE_OPTIONS="$NODE_OPTIONS ..." in package.json scripts is an established convention in the pnpm/pnpm repository and is used across many packages (e.g., fs/hard-link-dir, worker, __utils__/scripts). Do not flag this as a cross-platform issue in individual files; if a change is needed, apply it as a repo-wide change in a separate PR. Scope this guidance to all package.json files in the repo; use the minimatch pattern '**/package.json' to identify relevant files and review changes at the repository level rather than per-file.
Applied to files:
package.json
📚 Learning: 2026-05-29T18:03:15.372Z
Learnt from: CR
Repo: pnpm/pnpm PR: 0
File: pacquet/AGENTS.md:0-0
Timestamp: 2026-05-29T18:03:15.372Z
Learning: Match how the same feature is implemented in the TypeScript pnpm CLI — any change in pacquet must match pnpm's behavior, logic, edge cases, config resolution, error messages, file/lockfile formats, and existing tests
Applied to files:
package.json
📚 Learning: 2026-05-29T18:03:15.372Z
Learnt from: CR
Repo: pnpm/pnpm PR: 0
File: pacquet/AGENTS.md:0-0
Timestamp: 2026-05-29T18:03:15.372Z
Learning: Applies to pacquet/**/tests/**/*.rs : Port relevant pnpm tests to Rust tests whenever they translate when porting behavior from pnpm
Applied to files:
package.json
📚 Learning: 2026-05-29T18:03:15.372Z
Learnt from: CR
Repo: pnpm/pnpm PR: 0
File: pacquet/AGENTS.md:0-0
Timestamp: 2026-05-29T18:03:15.372Z
Learning: The `pre-push` hook runs `pacquet/scripts/pre-push-rust.sh` which checks `rustfmt`, `taplo`, `cargo doc` with `-D warnings`, and `cargo dylint`
Applied to files:
package.json
📚 Learning: 2026-05-29T18:03:15.372Z
Learnt from: CR
Repo: pnpm/pnpm PR: 0
File: pacquet/AGENTS.md:0-0
Timestamp: 2026-05-29T18:03:15.372Z
Learning: Applies to pacquet/**/tests/**/*.rs : Tests that need the mocked registry should start `pnpr` through `pacquet-testing-utils`; `cargo test` / `cargo nextest run` should not require a separate `just registry-mock launch` step
Applied to files:
package.json
📚 Learning: 2026-05-29T18:03:24.797Z
Learnt from: CR
Repo: pnpm/pnpm PR: 0
File: pnpr/AGENTS.md:0-0
Timestamp: 2026-05-29T18:03:24.797Z
Learning: Applies to pnpr/**/pnpr/**/*.rs : Follow the pacquet contributing guide (../pacquet/CONTRIBUTING.md) for test layout and Rust conventions
Applied to files:
package.json
📚 Learning: 2026-05-29T18:03:24.797Z
Learnt from: CR
Repo: pnpm/pnpm PR: 0
File: pnpr/AGENTS.md:0-0
Timestamp: 2026-05-29T18:03:24.797Z
Learning: Run 'just check', 'just test', 'just lint', and 'just fmt' before declaring work done
Applied to files:
package.json
📚 Learning: 2026-05-29T18:03:24.797Z
Learnt from: CR
Repo: pnpm/pnpm PR: 0
File: pnpr/AGENTS.md:0-0
Timestamp: 2026-05-29T18:03:24.797Z
Learning: Applies to pnpr/**/pnpr/**/*.rs : Follow the pacquet code-style guide (../pacquet/CODE_STYLE_GUIDE.md) for Rust-level conventions including imports, naming, ownership, and error handling
Applied to files:
package.json
📚 Learning: 2026-05-29T18:03:15.372Z
Learnt from: CR
Repo: pnpm/pnpm PR: 0
File: pacquet/AGENTS.md:0-0
Timestamp: 2026-05-29T18:03:15.372Z
Learning: Applies to pacquet/**/tests/**/*.rs : Prefer `#[cfg_attr(target_os = "windows", ignore = "...")]` (or matching `#[cfg(unix)]` gates) over runtime probe-and-skip helpers for platform-locked tools
Applied to files:
package.json
🔇 Additional comments (1)
package.json (1)
20-20:pnxsupports semver ranges innode@runtime:<spec>selectors.
pnx node@runtime:^26.3.0is valid: pacquet’sparse_node_specifieraccepts any semver range afterruntime:and forwards it toresolve_node_version, and the repo lockfile already usesspecifier: runtime:^26.3.0.
Contributor
Integrated-Benchmark Report (Linux)Each scenario reports direct installs and pnpr installs. Bencher consumes pacquet@HEAD and pnpr@HEAD. Scenario: Isolated linker: fresh restore, cold cache + cold store
BENCHMARK_REPORT.json{
"results": [
{
"command": "pacquet@HEAD",
"mean": 10.34054619652,
"stddev": 0.12552550828748366,
"median": 10.300247367019999,
"user": 3.40876466,
"system": 3.2964831599999997,
"min": 10.22598396252,
"max": 10.64406365952,
"times": [
10.46082312152,
10.64406365952,
10.24921724452,
10.31238400252,
10.28126063352,
10.332689287520001,
10.351150997520001,
10.259778324520001,
10.22598396252,
10.28811073152
]
},
{
"command": "pacquet@main",
"mean": 10.351253402720001,
"stddev": 0.16860990144668894,
"median": 10.27619532252,
"user": 3.3936314599999995,
"system": 3.2911889599999995,
"min": 10.213062223520001,
"max": 10.746234582520001,
"times": [
10.39147709052,
10.28424158652,
10.33563253952,
10.24854075352,
10.26814905852,
10.746234582520001,
10.24289589052,
10.213062223520001,
10.53610383952,
10.24619646252
]
},
{
"command": "pnpr@HEAD",
"mean": 5.510274041320001,
"stddev": 0.17986479937444236,
"median": 5.4402478500199996,
"user": 2.66175056,
"system": 2.9823786599999993,
"min": 5.31562945452,
"max": 5.81442244352,
"times": [
5.31562945452,
5.81442244352,
5.4363199795199995,
5.36073406552,
5.61727553452,
5.62845089252,
5.36047478052,
5.44417572052,
5.75657723252,
5.368680309519999
]
},
{
"command": "pnpr@main",
"mean": 5.378148609919999,
"stddev": 0.035832109154349194,
"median": 5.36958291802,
"user": 2.67751176,
"system": 3.0064126599999996,
"min": 5.333265186519999,
"max": 5.4547792265199995,
"times": [
5.41624216552,
5.4547792265199995,
5.36510587452,
5.3580752795199995,
5.36902267052,
5.3414058965199995,
5.37014316552,
5.333265186519999,
5.38653797752,
5.38690865652
]
}
]
}Scenario: Isolated linker: fresh restore, hot cache + hot store
BENCHMARK_REPORT.json{
"results": [
{
"command": "pacquet@HEAD",
"mean": 0.6485593264,
"stddev": 0.010593296596512234,
"median": 0.6475796572000001,
"user": 0.37805652,
"system": 1.3250590599999998,
"min": 0.6339012477,
"max": 0.6669440347000001,
"times": [
0.6459008957000001,
0.6339012477,
0.6397647297000001,
0.6669440347000001,
0.6608116457000001,
0.6378168537000001,
0.6440539167,
0.6492584187,
0.6578225837,
0.6493189377
]
},
{
"command": "pacquet@main",
"mean": 0.6828608615000001,
"stddev": 0.02373925823866274,
"median": 0.6884915022,
"user": 0.39452331999999996,
"system": 1.3434643599999998,
"min": 0.6476973397000001,
"max": 0.7258132117,
"times": [
0.6584607347000001,
0.6941471277000001,
0.7258132117,
0.6625860957,
0.6657521727000001,
0.6996945437000001,
0.6871243367000001,
0.6974743847000001,
0.6476973397000001,
0.6898586677
]
},
{
"command": "pnpr@HEAD",
"mean": 0.779135398,
"stddev": 0.05967082242868055,
"median": 0.7613796402000002,
"user": 0.3972641199999999,
"system": 1.3412967599999999,
"min": 0.7383664097000001,
"max": 0.9375292297000001,
"times": [
0.7601182217000001,
0.7383664097000001,
0.8108939847000001,
0.7734127767000001,
0.7437579157,
0.9375292297000001,
0.7741589057000001,
0.7626410587000001,
0.7404816727000001,
0.7499938047000001
]
},
{
"command": "pnpr@main",
"mean": 0.7620816541000001,
"stddev": 0.025353917785883435,
"median": 0.7515323092000001,
"user": 0.38522631999999996,
"system": 1.3275770599999999,
"min": 0.7411409137,
"max": 0.8208050117000001,
"times": [
0.7890520557,
0.7631550837000001,
0.7528519407,
0.7685706907000001,
0.7411409137,
0.8208050117000001,
0.7492691717000001,
0.7502126777000001,
0.7426396627,
0.7431193327000001
]
}
]
}Scenario: Isolated linker: fresh install, cold cache + cold store
BENCHMARK_REPORT.json{
"results": [
{
"command": "pacquet@HEAD",
"mean": 9.29382552202,
"stddev": 0.03170233175717623,
"median": 9.29529614232,
"user": 3.6842291999999994,
"system": 3.27881152,
"min": 9.25334646732,
"max": 9.34365095132,
"times": [
9.32129344532,
9.34365095132,
9.27032691832,
9.32900986532,
9.25582554232,
9.30750361932,
9.25334646732,
9.29738518532,
9.26670612632,
9.29320709932
]
},
{
"command": "pacquet@main",
"mean": 9.27481105192,
"stddev": 0.043722580336474005,
"median": 9.26864548432,
"user": 3.6938731999999996,
"system": 3.2891356200000006,
"min": 9.19508680232,
"max": 9.35332142832,
"times": [
9.27139941432,
9.29854918032,
9.19508680232,
9.30794889132,
9.25717276132,
9.30514428832,
9.26589155432,
9.23868441632,
9.35332142832,
9.25491178232
]
},
{
"command": "pnpr@HEAD",
"mean": 5.07612119282,
"stddev": 0.04791208708237304,
"median": 5.0606121773199995,
"user": 2.3893584,
"system": 2.77810302,
"min": 5.02306011632,
"max": 5.17630563632,
"times": [
5.06342550732,
5.04284613432,
5.05779884732,
5.02306011632,
5.09782333432,
5.06561769632,
5.03877736332,
5.17630563632,
5.13833499832,
5.05722229432
]
},
{
"command": "pnpr@main",
"mean": 5.134076823519999,
"stddev": 0.09357958875001847,
"median": 5.1029049868200005,
"user": 2.3942329999999994,
"system": 2.83025382,
"min": 5.04572449832,
"max": 5.34253436732,
"times": [
5.08231668132,
5.12561658532,
5.12349329232,
5.06438641932,
5.07452666432,
5.34253436732,
5.23625055632,
5.04572449832,
5.07003868532,
5.1758804853200004
]
}
]
}Scenario: Isolated linker: fresh install, hot cache + hot store
BENCHMARK_REPORT.json{
"results": [
{
"command": "pacquet@HEAD",
"mean": 1.4782305014800001,
"stddev": 0.019656956217876803,
"median": 1.47581865078,
"user": 1.5977086999999999,
"system": 1.8362029999999998,
"min": 1.4493193912800002,
"max": 1.5139760482800002,
"times": [
1.47328166228,
1.4649930342800002,
1.5139760482800002,
1.4783556392800001,
1.4873948722800001,
1.4862610042800002,
1.50067466328,
1.47138591128,
1.4493193912800002,
1.45666278828
]
},
{
"command": "pacquet@main",
"mean": 1.4648146019800001,
"stddev": 0.010264736285625397,
"median": 1.46616514828,
"user": 1.6087571,
"system": 1.8118349999999999,
"min": 1.44689538128,
"max": 1.47670514128,
"times": [
1.46408503728,
1.47670514128,
1.44987199228,
1.4695719852800002,
1.44689538128,
1.47455346528,
1.46210665428,
1.4608306642800002,
1.4682452592800002,
1.47528043928
]
},
{
"command": "pnpr@HEAD",
"mean": 0.7100981069800001,
"stddev": 0.07883749464756337,
"median": 0.6831182977800001,
"user": 0.34442529999999993,
"system": 1.3103341999999998,
"min": 0.67826871328,
"max": 0.9337099172800001,
"times": [
0.9337099172800001,
0.6932656512800001,
0.68029876428,
0.67963261228,
0.68144664328,
0.6847899522800001,
0.67826871328,
0.68053370128,
0.69560247328,
0.69343264128
]
},
{
"command": "pnpr@main",
"mean": 0.6997986452800001,
"stddev": 0.06941885972008818,
"median": 0.6742479272799999,
"user": 0.3386912999999999,
"system": 1.2721829,
"min": 0.65019685928,
"max": 0.87767005428,
"times": [
0.7621102602800001,
0.67165464428,
0.67721874228,
0.68032709928,
0.87767005428,
0.66915880528,
0.65019685928,
0.66887580728,
0.66393297028,
0.67684121028
]
}
]
}Scenario: Isolated linker: fresh install, cold cache + hot store
BENCHMARK_REPORT.json{
"results": [
{
"command": "pacquet@HEAD",
"mean": 5.12205450992,
"stddev": 0.026911162644216398,
"median": 5.12624642612,
"user": 1.8208285399999997,
"system": 2.04073636,
"min": 5.06539251412,
"max": 5.16369593612,
"times": [
5.13826388112,
5.16369593612,
5.11009627212,
5.13786958012,
5.12195632112,
5.06539251412,
5.130536531120001,
5.11096119612,
5.1398561671200005,
5.10191670012
]
},
{
"command": "pacquet@main",
"mean": 5.113692689719999,
"stddev": 0.03643199100035146,
"median": 5.1221285096199995,
"user": 1.8560067400000002,
"system": 1.9494806599999996,
"min": 5.03049607412,
"max": 5.146956262120001,
"times": [
5.11906027812,
5.0734099091200004,
5.1451290721200005,
5.03049607412,
5.11828661712,
5.12519674112,
5.12875039612,
5.10679499112,
5.146956262120001,
5.14284655612
]
},
{
"command": "pnpr@HEAD",
"mean": 0.7269718082200002,
"stddev": 0.02931412969215391,
"median": 0.72139363162,
"user": 0.35265704,
"system": 1.3211141599999998,
"min": 0.7026825151200001,
"max": 0.8013555481200001,
"times": [
0.8013555481200001,
0.71122070412,
0.7444841861200001,
0.7035025291200001,
0.7193977561200001,
0.7255046851200001,
0.7066649801200001,
0.7026825151200001,
0.72338950712,
0.73151567112
]
},
{
"command": "pnpr@main",
"mean": 0.6935981485200001,
"stddev": 0.06468182030188299,
"median": 0.6727471546200001,
"user": 0.33925503999999995,
"system": 1.2730442599999998,
"min": 0.6586367901200001,
"max": 0.8743269341200001,
"times": [
0.7008642641200001,
0.6793686211200001,
0.6604229481200001,
0.6661078211200001,
0.8743269341200001,
0.6825569491200001,
0.6586367901200001,
0.6682028481200001,
0.66954518612,
0.6759491231200001
]
}
]
} |
Contributor
|
Bencher Report| Branch | pr/12261 |
| Testbed | pacquet |
Click to view all benchmark results
| Benchmark | Latency | Benchmark Result milliseconds (ms) (Result Δ%) | Upper Boundary milliseconds (ms) (Limit %) |
|---|---|---|---|
| isolated-linker.fresh-install.cold-cache.cold-store | 📈 view plot 🚷 view threshold | 9,293.83 ms(+18.08%)Baseline: 7,870.61 ms | 9,444.73 ms (98.40%) |
| isolated-linker.fresh-install.cold-cache.hot-store | 📈 view plot 🚷 view threshold | 5,122.05 ms(+1.99%)Baseline: 5,022.02 ms | 6,026.43 ms (84.99%) |
| isolated-linker.fresh-install.hot-cache.hot-store | 📈 view plot 🚷 view threshold | 1,478.23 ms(+4.27%)Baseline: 1,417.71 ms | 1,701.25 ms (86.89%) |
| isolated-linker.fresh-restore.cold-cache.cold-store | 📈 view plot 🚷 view threshold | 10,340.55 ms(+6.99%)Baseline: 9,665.28 ms | 11,598.33 ms (89.16%) |
| isolated-linker.fresh-restore.hot-cache.hot-store | 📈 view plot 🚷 view threshold | 648.56 ms(-1.40%)Baseline: 657.75 ms | 789.30 ms (82.17%) |
b0b1513 to
25353f8
Compare
Code Review by Qodo
1. Runtime version becomes undefined
|
25353f8 to
1fd4de7
Compare
|
Code review by qodo was updated up to the latest commit 1fd4de7 |
Contributor
|
| Branch | pr/12261 |
| Testbed | pnpr |
⚠️ WARNING: No Threshold found!Without a Threshold, no Alerts will ever be generated.
Click here to create a new Threshold
For more information, see the Threshold documentation.
To only post results if a Threshold exists, set the--ci-only-thresholdsflag.
Click to view all benchmark results
| Benchmark | Latency | milliseconds (ms) |
|---|---|---|
| isolated-linker.fresh-install.cold-cache.cold-store | 📈 view plot | 5,076.12 ms |
| isolated-linker.fresh-install.cold-cache.hot-store | 📈 view plot | 726.97 ms |
| isolated-linker.fresh-install.hot-cache.hot-store | 📈 view plot | 710.10 ms |
| isolated-linker.fresh-restore.cold-cache.cold-store | 📈 view plot | 5,510.27 ms |
| isolated-linker.fresh-restore.hot-cache.hot-store | 📈 view plot | 779.14 ms |
|
Code review by qodo was updated up to the latest commit 6ef8897 |
Member
Author
|
@coderabbitai approve |
✅ Action performedComments resolved and changes approved. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This automated PR refreshes the project's pinned versions:
packageManageranddevEngines.packageManager).@pnpm/pacquetconfig dependency to its latest release.Created by the update-lockfile workflow.
Summary by CodeRabbit
@pnpm/pacquetto 0.11.2 to pick up the latest fixes and improvements.