fix: expose update --no-save in CLI help by orgads · Pull Request #12091 · pnpm/pnpm

orgads · 2026-05-31T15:00:56Z

The update command already honors --no-save and the docs already mention it, but the flag was missing from the update command metadata.

Add the option entry so pnpm update --help shows it and the CLI surface matches the documented behavior.

Summary by CodeRabbit

Bug Fixes
- The --no-save option for pnpm update is now properly displayed in CLI help, allowing users to prevent package.json range updates.

The update command already honors --no-save and the docs already mention it, but the flag was missing from the update command metadata. Add the option entry so pnpm update --help shows it and the CLI surface matches the documented behavior.

welcome · 2026-05-31T15:00:58Z

💖 Thanks for opening this pull request! 💖
Please be patient and we will get back to you as soon as we can.

coderabbitai · 2026-05-31T15:01:10Z

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 01268a95-4114-45ca-a8ca-4141a496174b

📥 Commits

Reviewing files that changed from the base of the PR and between 54d2b57 and 7e79a25.

📒 Files selected for processing (2)

.changeset/fix-update-no-save-option.md
installing/commands/src/update/index.ts

📜 Recent review details

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (2)

GitHub Check: Analyze (javascript)
GitHub Check: Compile & Lint

🧰 Additional context used

📓 Path-based instructions (1)

**/*.{ts,tsx}

📄 CodeRabbit inference engine (AGENTS.md)

**/*.{ts,tsx}: Follow Standard Style with trailing commas, preferring functions over classes, and declaring functions after they are used (relying on hoisting)
Use a single options object instead of multiple parameters when a function needs more than two or three arguments
Follow Import Order: Standard libraries first, then external dependencies (alphabetically), then relative imports
Write self-documenting code where function names, parameters, and types explain what a function does without requiring prose comments
Do not write comments that restate what the code already says; refactor via renaming, splitting helpers, or restructuring instead
Do not repeat documentation at call sites that already exists in JSDoc on the callee; update JSDoc once for all call sites to benefit
Use JSDoc only for a function's contract (preconditions, postconditions, edge cases, why the function exists), not for re-narrating the body
Do not record past implementation shape, refactor history, or 'the previous code did X' framing in code; use git log and git blame instead
Write comments only when: the reason for code is non-obvious (hidden invariant, workaround for known bug, deliberate exception), or the right name doesn't fit (temporary technical constraint)

Files:

installing/commands/src/update/index.ts

🧠 Learnings (2)

📚 Learning: 2026-05-26T21:01:06.666Z

Learnt from: zkochan
Repo: pnpm/pnpm PR: 11966
File: .changeset/require-tarball-integrity.md:6-6
Timestamp: 2026-05-26T21:01:06.666Z
Learning: In pnpm lockfile-related release notes/docs (especially changeset markdown), preserve URL hostnames exactly as they appear in pnpm-lock.yaml tarball resolution entries—keep hosts like `codeload.github.com`, `bitbucket.org`, and `gitlab.com` in lowercase. Do not “correct” them to title-case/preserve brand capitalization (e.g., LanguageTool rules like `GITHUB` capitalization) because these are literal URL fragments, not platform brand names.

Applied to files:

.changeset/fix-update-no-save-option.md

📚 Learning: 2026-05-14T09:04:00.133Z

Learnt from: zkochan
Repo: pnpm/pnpm PR: 11622
File: resolving/npm-resolver/test/publishedBy.test.ts:350-354
Timestamp: 2026-05-14T09:04:00.133Z
Learning: In the pnpm/pnpm repository, ESLint is the authoritative style linter. Do not raise review findings for missing trailing commas in multiline function calls (e.g., `fs.writeFileSync(...)`) when this repo’s ESLint configuration does not report them and lint passes. Prefer deferring to the ESLint results for this specific trailing-comma rule rather than enforcing it manually in code review.

Applied to files:

installing/commands/src/update/index.ts

🔇 Additional comments (2)

installing/commands/src/update/index.ts (1)

154-157: LGTM!

.changeset/fix-update-no-save-option.md (1)

1-6: LGTM!

📝 Walkthrough

Walkthrough

The PR registers the --no-save flag in the pnpm update command by adding help text documentation and declaring patch version bumps. The implementation adds a single option entry to the help text; the changeset formalizes the release metadata.

Changes

CLI Help Registration

Layer / File(s)	Summary
Update command help text and changeset `installing/commands/src/update/index.ts`, `.changeset/fix-update-no-save-option.md`	Help text entry documents the `--no-save` flag, which prevents package.json dependency ranges from being updated. Changeset declares patch releases for `@pnpm/installing.commands` and `pnpm`.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Poem

🐰 A flag once lost, now found and shown,
The help text speaks of --no-save grown,
In package.json's ranges, frozen still,
Through changeset's word, the truth we'll trill! 📝

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%.	Write docstrings for the functions missing them to satisfy the coverage threshold.

✅ Passed checks (4 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title 'fix: expose update --no-save in CLI help' accurately summarizes the main change—registering the --no-save flag in the CLI help for the update command.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

🧪 Generate unit tests (beta)

Create PR with unit tests

Warning

There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure.

🔧 ESLint

If the error stems from missing dependencies, add them to the package.json file. For unrecoverable errors (e.g., due to private dependencies), disable the tool in the CodeRabbit configuration.

ESLint install failed. For unrecoverable errors, disable the tool in CodeRabbit configuration.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

qodo-free-for-open-source-projects · 2026-05-31T15:01:19Z

Review Summary by Qodo

Expose update --no-save flag in CLI help

🐞 Bug fix

Walkthroughs

Description

• Expose --no-save flag in update command CLI help
• Register missing option in command metadata
• Align CLI surface with documented behavior

Diagram

flowchart LR
  A["update command metadata"] -- "add --no-save option" --> B["CLI help displays flag"]
  C["documented behavior"] -- "now matches" --> B

File Changes

1. installing/commands/src/update/index.ts 🐞 Bug fix +4/-0

Register --no-save option in update command

• Added --no-save option entry to update command options array
• Includes description explaining the flag prevents package.json range updates
• Positioned alongside other update-specific options like --interactive

installing/commands/src/update/index.ts

2. .changeset/fix-update-no-save-option.md 📝 Documentation +6/-0

Add changeset for --no-save option fix

• Created changeset file documenting the fix
• Marks patch version bump for both @pnpm/installing.commands and pnpm packages
• Describes the registration of --no-save flag in CLI help

.changeset/fix-update-no-save-option.md

Copilot

Pull request overview

Adds the missing --no-save flag entry to the pnpm update command's help metadata so it appears in pnpm update --help, matching already-documented and implemented behavior.

Changes:

Add --no-save option descriptor to the update command's option list.
Add a changeset entry describing the fix.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File	Description
installing/commands/src/update/index.ts	Adds the `--no-save` option entry to the update command help metadata.
.changeset/fix-update-no-save-option.md	Patch-level changeset for `@pnpm/installing.commands` and `pnpm`.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

welcome · 2026-06-17T06:22:13Z

Congrats on merging your first pull request! 🎉🎉🎉

fix: expose update --no-save in CLI help

7e79a25

The update command already honors --no-save and the docs already mention it, but the flag was missing from the update command metadata. Add the option entry so pnpm update --help shows it and the CLI surface matches the documented behavior.

orgads requested a review from zkochan as a code owner May 31, 2026 15:00

Copilot AI review requested due to automatic review settings May 31, 2026 15:00

Copilot started reviewing on behalf of orgads May 31, 2026 15:01 View session

Copilot AI reviewed May 31, 2026

View reviewed changes

coderabbitai Bot approved these changes May 31, 2026

View reviewed changes

btea approved these changes Jun 1, 2026

View reviewed changes

zkochan approved these changes Jun 17, 2026

View reviewed changes

zkochan merged commit 9d79ba1 into pnpm:main Jun 17, 2026
14 of 16 checks passed

orgads deleted the up-no-save branch June 17, 2026 08:27

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

fix: expose update --no-save in CLI help#12091

fix: expose update --no-save in CLI help#12091
zkochan merged 1 commit into
pnpm:mainfrom
orgads:up-no-save

orgads commented May 31, 2026 •

edited by coderabbitai Bot

Loading

Uh oh!

welcome Bot commented May 31, 2026

Uh oh!

coderabbitai Bot commented May 31, 2026 •

edited

Loading

Walkthrough

Changes

Estimated code review effort

Poem

❌ Failed checks (1 warning)

Uh oh!

qodo-free-for-open-source-projects Bot commented May 31, 2026

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

welcome Bot commented Jun 17, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Uh oh!

Uh oh!

Conversation

orgads commented May 31, 2026 • edited by coderabbitai Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary by CodeRabbit

Uh oh!

welcome Bot commented May 31, 2026

Uh oh!

coderabbitai Bot commented May 31, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

Estimated code review effort

Poem

❌ Failed checks (1 warning)

Uh oh!

qodo-free-for-open-source-projects Bot commented May 31, 2026

Review Summary by Qodo

Walkthroughs

File Changes

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

welcome Bot commented Jun 17, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

orgads commented May 31, 2026 •

edited by coderabbitai Bot

Loading

coderabbitai Bot commented May 31, 2026 •

edited

Loading