Skip to content

ci(pacquet): pin cargo-dylint to 6.0.0 to unblock CI#11969

Merged
zkochan merged 1 commit into
mainfrom
pin-cargo-dylint-6-0-0
May 26, 2026
Merged

ci(pacquet): pin cargo-dylint to 6.0.0 to unblock CI#11969
zkochan merged 1 commit into
mainfrom
pin-cargo-dylint-6-0-0

Conversation

@zkochan

@zkochan zkochan commented May 26, 2026

Copy link
Copy Markdown
Member

Summary

trailofbits/dylint 6.0.1 (published 2026-05-26 17:51 UTC) ships prebuilt cargo-binstall artifacts whose driver-bootstrap step references the dylint repo's own CI workspace path:

error: failed to get `dylint_driver` as a dependency of package
  `dylint_driver-nightly-2026-04-16-x86_64-unknown-linux-gnu v0.1.0`
Caused by:
  failed to read `/home/runner/work/dylint/dylint/driver/Cargo.toml`
Caused by:
  No such file or directory (os error 2)

Downstream runners don't have /home/runner/work/dylint/dylint/, so the bootstrap fails before any lint runs and the Dylint job goes red on every open PR (e.g. #11967, #11968). 6.0.0 — the version main was green on 90 minutes before the release dropped — is unaffected.

Pin both cargo-dylint and dylint-link to 6.0.0 until upstream cuts 6.0.2.

Test plan


Written by an agent (Claude Code, claude-opus-4-7).

Summary by CodeRabbit

  • Chores
    • Updated GitHub Actions CI/CD workflow configuration to use pinned versions of build dependencies for improved stability and consistency.

Review Change Stack

trailofbits/dylint 6.0.1 (published 2026-05-26 17:51 UTC) ships
prebuilt cargo-binstall artifacts that bake in a path from the
dylint repo's own CI workspace:

    error: failed to get `dylint_driver` as a dependency of package
      `dylint_driver-nightly-2026-04-16-x86_64-unknown-linux-gnu`
    Caused by:
      failed to read `/home/runner/work/dylint/dylint/driver/Cargo.toml`
    Caused by:
      No such file or directory (os error 2)

Downstream runners don't have that workspace, so the driver bootstrap
fails before any lint runs and the Dylint job goes red on every PR.
6.0.0 (the version main was passing with 90 minutes earlier) is
unaffected. Pin both binaries until upstream cuts 6.0.2.

---
Written by an agent (Claude Code, claude-opus-4-7).
@qodo-free-for-open-source-projects

Copy link
Copy Markdown

Review Summary by Qodo

Pin cargo-dylint and dylint-link to 6.0.0 to fix CI

🐞 Bug fix

Grey Divider

Walkthroughs

Description
• Pin cargo-dylint and dylint-link to 6.0.0 to fix CI failures
• Version 6.0.1 contains broken binstall artifacts with hardcoded paths
• Unblocks Dylint job that was failing on all PRs
Diagram
flowchart LR
  A["dylint 6.0.1 release"] -->|"broken binstall artifacts"| B["CI job fails"]
  C["Pin to 6.0.0"] -->|"working version"| D["CI job passes"]

Loading

Grey Divider

File Changes

1. .github/workflows/pacquet-ci.yml 🐞 Bug fix +7/-1

Pin dylint tools to 6.0.0 to fix bootstrap

• Pin cargo-dylint and dylint-link packages to version 6.0.0
• Add detailed comment explaining the 6.0.1 regression with hardcoded workspace paths
• Prevent driver bootstrap failures caused by missing /home/runner/work/dylint/dylint/ path

.github/workflows/pacquet-ci.yml


Grey Divider

Qodo Logo

@coderabbitai

coderabbitai Bot commented May 26, 2026

Copy link
Copy Markdown

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 9466b163-8297-486b-ac5f-22eb36dd6a86

📥 Commits

Reviewing files that changed from the base of the PR and between f107b1e and be60965.

📒 Files selected for processing (1)
  • .github/workflows/pacquet-ci.yml
📜 Recent review details
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (7)
  • GitHub Check: Analyze (javascript)
  • GitHub Check: Lint and Test (ubuntu-latest)
  • GitHub Check: Doc
  • GitHub Check: Lint and Test (windows-latest)
  • GitHub Check: Dylint
  • GitHub Check: Lint and Test (macos-latest)
  • GitHub Check: Compile & Lint
🔇 Additional comments (1)
.github/workflows/pacquet-ci.yml (1)

268-274: LGTM!


📝 Walkthrough

Walkthrough

The PR updates the GitHub Actions CI workflow to pin cargo-dylint and dylint-link to version 6.0.0 in the dylint job's dependency installation step, with inline comments documenting the reason for the version constraint due to incompatibilities with newer versions.

Changes

Dylint Tool Version Pinning

Layer / File(s) Summary
Pin cargo-dylint and dylint-link to version 6.0.0
.github/workflows/pacquet-ci.yml
The binstall step's packages input is updated to explicitly pin cargo-dylint@6.0.0 and dylint-link@6.0.0 with inline comments explaining the temporary pin due to incompatibilities with newer dylint/driver-bootstrap behavior.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Poem

🐰 A pinned version here, a lock in place,
Cargo tools stay steady in their chase,
Six-point-oh keeps the linting free,
No breaking changes for this rabbit spree! ✨

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and specifically summarizes the main change: pinning cargo-dylint to version 6.0.0 to resolve a CI blocking issue. It is concise, directly related to the primary objective of the PR, and provides sufficient context for developers reviewing the history.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch pin-cargo-dylint-6-0-0

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@zkochan zkochan merged commit 89c2b52 into main May 26, 2026
19 checks passed
@zkochan zkochan deleted the pin-cargo-dylint-6-0-0 branch May 26, 2026 18:59
@zkochan zkochan mentioned this pull request May 27, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant