pacquet/crates/resolving-deps-resolver/src/tests.rs (2)

789-789: 💤 Low value

Minor: Simplify iteration to use names only.

The second tuple element is unused. Consider iterating over names directly for clarity:

♻️ Simplification

-        for (name, _) in &[("foo", ""), ("bar", ""), ("qar", ""), ("zoo", "")] {
+        for name in &["foo", "bar", "qar", "zoo"] {
             let prefix = format!("{name}`@1.0.0`");

🤖 Prompt for AI Agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@pacquet/crates/resolving-deps-resolver/src/tests.rs` at line 789, The
for-loop in tests.rs currently iterates over tuples with an unused second
element using the pattern (name, _); replace that with a direct iteration over
the names collection (e.g., iterate over a slice/array of string literals) and
bind only a single variable (name) to improve clarity and remove the unused
placeholder; update the loop header where it currently reads for (name, _) in
&[("foo", ""), ("bar", ""), ("qar", ""), ("zoo", "")] to iterate over just the
names.

---

691-696: 💤 Low value

Consider more concise test doc comments per coding guidelines.

The doc comments for these four tests extensively narrate the test structure, dependency shapes, and expected outcomes. According to the coding guidelines: "Tests are documentation. Do not duplicate them in prose" and "Doc comments document the contract... not a re-narration of the body."

The upstream test references (e.g., installing/deps-resolver/test/resolvePeers.ts:14) are valuable for traceability and should be retained. However, the detailed shape descriptions and expected-outcome narratives duplicate what the test code itself demonstrates.

📝 Example of more concise documentation

For example, cyclic_peer_dependencies_resolve_cleanly could be trimmed to:

/// Cyclic peer dependencies resolve without panicking and produce
/// correctly prefixed peer-suffixed depPaths. Ports upstream's
/// `'resolve peer dependencies of cyclic dependencies'`
/// (installing/deps-resolver/test/resolvePeers.ts:14).
#[tokio::test]
async fn cyclic_peer_dependencies_resolve_cleanly() {

The test code itself documents the specific dependency shape and assertions.

As per coding guidelines: "Write code that explains itself" and "Tests are documentation."

Also applies to: 798-819, 916-935, 1011-1022

🤖 Prompt for AI Agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@pacquet/crates/resolving-deps-resolver/src/tests.rs` around lines 691 - 696,
Trim the verbose doc comments for the four tests (including
cyclic_peer_dependencies_resolve_cleanly and the three subsequent tests in the
same test module) to a short 1–2 line contract-style summary that states the
high-level behavior being verified and keeps the upstream reference (e.g.,
'installing/deps-resolver/test/resolvePeers.ts:14'), removing the detailed
dependency-shape narration and expected-outcome rehash that duplicates the test
body; leave the assertions and test code intact so the specifics remain in code
rather than prose.