auth/commands/test/login.test.ts (1)

211-239: ⚡ Quick win

Add explicit tests for invalid scope values handled by normalization.

Please add cases for scope: ' ' and scope: '@' to assert no @...:registry entry is written, matching the new guard paths in normalizeScope.

Proposed test addition

+  it('should not write a scope mapping for blank or invalid scope values', async () => {
+    for (const scope of ['   ', '@']) {
+      let savedSettings: Record<string, unknown> = {}
+      const context = createMockContext({
+        globalInfo: jest.fn(),
+        readIniFile: async () => ({}),
+        writeIniFile: async (_configPath, settings) => {
+          savedSettings = settings
+        },
+        fetch: async url => {
+          if (url === 'https://example.com/-/v1/login') {
+            return createMockResponse({
+              ok: true,
+              status: 200,
+              json: {
+                loginUrl: 'https://example.com/auth/login',
+                doneUrl: 'https://example.com/auth/done',
+              },
+            })
+          }
+          return createMockResponse({ ok: true, status: 200, json: { token: 'tok' } })
+        },
+      })
+      await login({ context, opts: { configDir: '/mock/config', dir: '/mock', authConfig: {}, registry: 'https://example.com', scope } })
+      for (const key of Object.keys(savedSettings)) {
+        expect(key.startsWith('@')).toBe(false)
+      }
+    }
+  })

🤖 Prompt for AI Agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@auth/commands/test/login.test.ts` around lines 211 - 239, Add two additional
test cases in auth/commands/test/login.test.ts mirroring the existing "should
not write a scope mapping when --scope is omitted" test but passing opts.scope =
'   ' and opts.scope = '@' respectively; use the same createMockContext stub and
savedSettings capture, call login({ context, opts }), and assert that no
savedSettings key starts with '@' (i.e., for each Object.keys(savedSettings)
expect(key.startsWith('@')).toBe(false)). Ensure the new tests reference the
same login invocation and savedSettings assertion so they exercise the
normalizeScope guard paths.