fix: check whether the path of overrides link is correct#10467
Open
btea wants to merge 5 commits into
Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This pull request adds validation for override link paths in the pnpm configuration to check if the linked paths actually exist. It addresses issue #10315 by warning users when they specify link: or file: overrides that point to non-existent paths.
Changes:
- Added
checkOverridesfunction to validate link and file path overrides - Added test coverage for both relative and absolute path validation
- Added changeset documenting the new feature
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 5 comments.
| File | Description |
|---|---|
| config/config/src/getOptionsFromRootManifest.ts | Implements path validation for link/file overrides using new checkOverrides function |
| config/config/test/getOptionsFromRootManifest.test.ts | Adds test cases for relative and absolute path override validation |
| .changeset/thirty-toes-drive.md | Documents the change as a minor version bump |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Member
|
I don't think it fixes what the referenced issue describes. The referenced issue is about the key in "overrides" that doesn't match anything during installation. |
Member
Author
|
Uh, that's right, I misread it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
close #10315