Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This pull request removes the pnpm server command functionality from pnpm. The server command was originally created for Glitch (a company that no longer exists), and the maintainers believe it's no longer being used. The functionality may be re-added as a plugin in the future if needed.
Changes:
- Removed the entire
@pnpm/serverpackage and@pnpm/plugin-commands-serverpackage - Renamed
createOrConnectStoreControllertocreateStoreControllerand simplified its implementation by removing server connection logic - Removed server-related configuration options (
use-running-store-server,use-store-server) - Removed server-related tests and dependencies
Reviewed changes
Copilot reviewed 50 out of 54 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| store/server/* | Removed entire server package including implementation, tests, and documentation |
| store/plugin-commands-server/* | Removed plugin commands for server management (start, stop, status) |
| store/store-connection-manager/src/index.ts | Simplified store controller creation by removing server connection logic and renaming functions |
| store/store-connection-manager/package.json | Removed dependencies on @pnpm/server and related packages |
| pnpm/src/cmd/index.ts | Removed server command from CLI command list |
| config/config/src/types.ts | Removed server-related configuration types |
| pkg-manager/plugin-commands-installation/src/* | Updated all imports to use renamed createStoreController function |
| pnpm/test/server.ts | Removed all server-related tests |
| cli/default-reporter/src/reporterForServer.ts | Removed server-specific reporter |
| pnpm-workspace.yaml | Removed unused catalog dependencies for server functionality |
Files not reviewed (1)
- pnpm-lock.yaml: Language not supported
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
pnpm serverwas created many years ago for Glitch. That company doesn't exist anymore and I don't think anyone uses this command. It was only useful for Glitch. If we will ever re-add this feature, we'll re-add it as a plugin.