Skip to content

pnpm patch folder not cmd/ctrl-clickable in VS Code #8513

@karlhorky

Description

@karlhorky

Verify latest release

  • I verified that the issue exists in the latest pnpm release

pnpm version

9.10.0

Which area(s) of pnpm are affected? (leave empty if unsure)

CLI

Link to the code that reproduces this issue or a replay of the bug

No response

Reproduction steps

  1. Run pnpm patch <package name>
  2. In VS Code, attempt to cmd/ctrl-click on the link, which (usually) opens the folder in the left panel VS Code File Explorer
  3. 💥 Observe that the folder is opened in macOS Finder or Windows Explorer instead
  4. Try a normal echo command with the same path and observe that it opens in the VS Code File Explorer
Kapture.2024-09-09.at.17.49.20.mp4

I'm thinking that maybe this is because of the dashed underline and the color on the text, which may mess with VS Code's algorithm for determining how the folder should be opened:

Screenshot 2024-09-09 at 18 01 57

Screenshot 2024-09-09 at 18 02 25

For now, maybe removing the styling on the path would be a good option?

cc @Tyriar, in case this is also a bug in the "Focus folder in explorer" implementation (original issue) - happy to also open a companion VS Code bug if that is desired.

Describe the Bug

The folder is opened in macOS Finder or Windows Explorer

Expected Behavior

The folder is opened in the VS Code File Explorer

Which Node.js version are you using?

20.15.0

Which operating systems have you used?

  • macOS
  • Windows
  • Linux

If your OS is a Linux based, which one it is? (Include the version if relevant)

No response

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions