Skip to content

Commit 7e3145f

Browse files
zkochanzkochan
authored
chore: add devEngines.runtime (#11553)
Adds `devEngines.runtime` to pin the Node.js version (24.6.0, `onFail: download`) the project uses for development, so contributors don't have to manage Node versions manually. CI changes that come with it: - Bumps pnpm to **11.1.1** and `pnpm/action-setup` to a bootstrap that ships `@zkochan/cmd-shim` 9.0.3. The cmd-shim update is required because the previous shim's `exec cmd /C` got mangled by Git Bash's MSYS path conversion (`/C` → Windows path), which broke any `pn …` invocation from `shell: bash` on Windows. - Switches the install step to `pn install --no-runtime` so the per-test-matrix Node version chosen by `pn runtime -g set node …` isn't overridden by the project-pinned 24.6.0. - Adds a `Verify Node version` step that asserts `pn node -v` matches the matrix's Node.
1 parent 9a32752 commit 7e3145f

8 files changed

Lines changed: 177 additions & 51 deletions

File tree

‎.github/workflows/audit.yml‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@ jobs:
1414
- name: Checkout Commit
1515
uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # v6.0.2
1616
- name: Install pnpm
17-
uses: pnpm/action-setup@e578e19d19d31b011b841ba2aca34731a5f706a5
17+
uses: pnpm/action-setup@0e279bb959325dab635dd2c09392533439d90093
1818
with:
1919
standalone: true
2020
- name: Audit

‎.github/workflows/benchmark.yml‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -47,7 +47,7 @@ jobs:
4747
echo "Checked out PR #$PR_NUMBER at $(git rev-parse --short HEAD)"
4848
4949
- name: Install pnpm
50-
uses: pnpm/action-setup@e578e19d19d31b011b841ba2aca34731a5f706a5
50+
uses: pnpm/action-setup@0e279bb959325dab635dd2c09392533439d90093
5151
with:
5252
standalone: true
5353

‎.github/workflows/ci.yml‎

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -19,12 +19,9 @@ jobs:
1919
- name: Checkout Commit
2020
uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # v6.0.2
2121
- name: Install pnpm
22-
uses: pnpm/action-setup@e578e19d19d31b011b841ba2aca34731a5f706a5
22+
uses: pnpm/action-setup@0e279bb959325dab635dd2c09392533439d90093
2323
with:
2424
standalone: true
25-
- name: Setup Node
26-
run: pn runtime -g set node 24.6.0
27-
timeout-minutes: 2
2825
- name: pnpm install
2926
run: pn install
3027
timeout-minutes: 3

‎.github/workflows/release.yml‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,7 @@ jobs:
2323
- name: Checkout
2424
uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # v6.0.2
2525
- name: Install pnpm
26-
uses: pnpm/action-setup@e578e19d19d31b011b841ba2aca34731a5f706a5
26+
uses: pnpm/action-setup@0e279bb959325dab635dd2c09392533439d90093
2727
with:
2828
standalone: true
2929
- name: Setup Node

‎.github/workflows/test.yml‎

Lines changed: 11 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -31,7 +31,7 @@ jobs:
3131
- name: Checkout Commit
3232
uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # v6.0.2
3333
- name: Install pnpm
34-
uses: pnpm/action-setup@e578e19d19d31b011b841ba2aca34731a5f706a5
34+
uses: pnpm/action-setup@0e279bb959325dab635dd2c09392533439d90093
3535
with:
3636
standalone: true
3737
- name: Setup Node
@@ -41,8 +41,17 @@ jobs:
4141
- name: Verify npm
4242
run: npm --version
4343
- name: pnpm install
44-
run: pn install
44+
run: pn install --no-runtime
4545
timeout-minutes: 3
46+
- name: Verify Node version
47+
shell: bash
48+
run: |
49+
actual=$(pn node -v)
50+
expected="v${{ inputs.node }}"
51+
if [ "$actual" != "$expected" ]; then
52+
echo "Expected Node version $expected but got $actual"
53+
exit 1
54+
fi
4655
- name: Download compiled artifacts
4756
uses: actions/download-artifact@70fc10c6e5e1ce46ad2ea6f2b72d43f7d47b13c3 # v8.0.0
4857
with:

‎.github/workflows/update-lockfile.yml‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,7 @@ jobs:
2020
token: ${{ secrets.UPDATE_LOCKFILE_TOKEN }}
2121

2222
- name: Install pnpm
23-
uses: pnpm/action-setup@e578e19d19d31b011b841ba2aca34731a5f706a5
23+
uses: pnpm/action-setup@0e279bb959325dab635dd2c09392533439d90093
2424
with:
2525
standalone: true
2626

‎package.json‎

Lines changed: 7 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -57,11 +57,16 @@
5757
"typescript": "catalog:",
5858
"verdaccio": "catalog:"
5959
},
60-
"packageManager": "pnpm@11.0.7",
60+
"packageManager": "pnpm@11.1.1",
6161
"devEngines": {
6262
"packageManager": {
6363
"name": "pnpm",
64-
"version": "11.0.7",
64+
"version": "11.1.1",
65+
"onFail": "download"
66+
},
67+
"runtime": {
68+
"name": "node",
69+
"version": "24.6.0",
6570
"onFail": "download"
6671
}
6772
}

‎pnpm-lock.yaml‎

Lines changed: 154 additions & 39 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

0 commit comments

Comments
 (0)