Skip to content
This repository was archived by the owner on May 14, 2026. It is now read-only.

fix(package-manager): add missing TarballResolution.path in installability test fixture#455

Merged
zkochan merged 1 commit into
mainfrom
fix/installability-tarball-path
May 13, 2026
Merged

fix(package-manager): add missing TarballResolution.path in installability test fixture#455
zkochan merged 1 commit into
mainfrom
fix/installability-tarball-path

Conversation

@zkochan

@zkochan zkochan commented May 13, 2026

Copy link
Copy Markdown
Member

Summary

Fixes the CI break on main. Landrace between two recently-merged PRs:

Both PRs were green against their own bases, but main's tip — where they're both applied — doesn't compile:

error[E0063]: missing field `path` in initializer of `TarballResolution`
  --> crates/package-manager/src/installability/tests.rs:56:49

Affected CI jobs on main: Lint and Test (macos-latest), Lint and Test (ubuntu-latest), Lint and Test (windows-latest), Dylint — all hitting the same cargo test --no-run failure.

Fix: add path: None to the struct literal. The installability check ignores the resolution shape (per the existing comment in the test fixture), so None is the truthful value.

Test plan

  • cargo nextest run -p pacquet-package-manager --locked installability — all 11 tests pass.

Written by an agent (Claude Code, claude-opus-4-7).

@zkochan
fix(package-manager): add missing path field in installability test…
c933bb9 
… fixture

Landrace between #439 (installability tests fixture) and #451 (added
`path: Option<String>` to `TarballResolution`). Both merged green
against their own bases but main's tip won't compile:

    error[E0063]: missing field `path` in initializer of `TarballResolution`
      --> crates/package-manager/src/installability/tests.rs:56:49

Add the missing field with `path: None` so the struct literal matches
the current `TarballResolution` shape.
Copilot AI review requested due to automatic review settings May 13, 2026 13:48
@coderabbitai

coderabbitai Bot commented May 13, 2026

Copy link
Copy Markdown

Warning

Rate limit exceeded

@zkochan has exceeded the limit for the number of commits that can be reviewed per hour. Please wait 1 minute and 31 seconds before requesting another review.

You’ve run out of usage credits. Purchase more in the billing tab.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 9e6e1ad1-02df-4e7a-81b7-ef782b21a58f

📥 Commits

Reviewing files that changed from the base of the PR and between cf125b1 and c933bb9.

📒 Files selected for processing (1)
  • crates/package-manager/src/installability/tests.rs
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/installability-tarball-path

Comment @coderabbitai help to get the list of available commands and usage tips.

@zkochan zkochan merged commit d791419 into main May 13, 2026
14 of 15 checks passed
@zkochan zkochan deleted the fix/installability-tarball-path branch May 13, 2026 13:51
Copilot AI reviewed May 13, 2026

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

@codecov

codecov Bot commented May 13, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 87.20%. Comparing base (34be005) to head (c933bb9).
⚠️ Report is 4 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main     #455      +/-   ##
==========================================
- Coverage   87.20%   87.20%   -0.01%     
==========================================
  Files         105      108       +3     
  Lines        8493     8805     +312     
==========================================
+ Hits         7406     7678     +272     
- Misses       1087     1127      +40

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@github-actions

github-actions Bot commented May 13, 2026

Copy link
Copy Markdown

Micro-Benchmark Results

Linux

group                          main                                   pr
-----                          ----                                   --
tarball/download_dependency    1.01     16.2±0.42ms   267.6 KB/sec    1.00     16.0±0.86ms   270.6 KB/sec

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

Copilot code review Copilot Copilot left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@zkochan