fix: extract pnpm version from packageManager field on Windows#216
Merged
fix: extract pnpm version from packageManager field on Windows#216
Conversation
…ing undefined When packageManager is set to e.g. "pnpm@9.1.0+sha...", strip the "pnpm@" prefix and any "+sha..." hash suffix so the action installs the correct version. Previously returning undefined caused failures on Windows.
|
Why is this Windows-specific? Why strip the values instead of using them? |
|
Where is the successful test that satisfies the test plan in the PR description? |
Member
Author
|
A code contribution would help more than posting a dozen of angry comments. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
packageManageris set (e.g.pnpm@9.1.0+sha...), the action now extracts the actual version instead of returningundefinedpnpm@prefix and any+sha...hash suffix to get the clean version stringundefinedcaused pnpm to not be installed correctlyTest plan
packageManagerfield is present inpackage.json