Skip to content

chore(workflows): adding pr-check.yaml to validate dist folder#213

Merged
zkochan merged 2 commits intopnpm:masterfrom
axel7083:chore/workflows/pr-check
Mar 19, 2026
Merged

chore(workflows): adding pr-check.yaml to validate dist folder#213
zkochan merged 2 commits intopnpm:masterfrom
axel7083:chore/workflows/pr-check

Conversation

@axel7083
Copy link
Copy Markdown
Contributor

Description

Adding a simple pr-check.yaml workflow that validate the dist folders against current source code; this ensure that the compiled code is matching the content of the src folder.

ℹ️ As we need to install pnpm, I used the latest version (v5.0.0) as we cannot trust the action of the PR, dependabot should handle this updates when new release will be made 👍

Related issues

Fixes #34

cc @KSXGitHub

@KSXGitHub KSXGitHub requested review from Copilot and zkochan March 19, 2026 10:34
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds a new GitHub Actions workflow intended to validate that the committed dist/ artifacts are up-to-date on pull requests (addressing #34).

Changes:

  • Introduces .github/workflows/pr-check.yaml to run update-pnpm-dist on PRs and fail if dist/ has diffs afterward.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

You can also share your feedback on Copilot code review. Take the survey.

Comment thread .github/workflows/pr-check.yaml Outdated
Comment thread .github/workflows/pr-check.yaml Outdated
Comment thread .github/workflows/pr-check.yaml Outdated
Signed-off-by: axel7083 <42176370+axel7083@users.noreply.github.com>
@axel7083 axel7083 force-pushed the chore/workflows/pr-check branch from 9a3d84c to d20abea Compare March 19, 2026 13:26
@axel7083
Copy link
Copy Markdown
Contributor Author

axel7083 commented Mar 19, 2026

Hey @KSXGitHub it seems that the current dist/index.js of the master branch is not matching the code in the src... I thought it was the workflow that was invalid, but it appears the problem is the current master does not seems to match the output we get using pnpm run build.

You can try it yourself

  1. git clone https://github.com/pnpm/action-setup
  2. cd action-setup
  3. pnpm install
  4. pnpm run build
  5. git diff --exit-code dist/index.js
  6. Assert last command exit 1 (failing)

@axel7083 axel7083 requested a review from KSXGitHub March 19, 2026 13:33
@KSXGitHub
Copy link
Copy Markdown
Collaborator

I see. Can you run build and update dist as well?

Signed-off-by: axel7083 <42176370+axel7083@users.noreply.github.com>
@zkochan zkochan merged commit 2e223e0 into pnpm:master Mar 19, 2026
26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

CI: Need a test to make sure dist/index.js up-to-date with the source code.

4 participants