Handle $ErrorActionPreference value#4079
Merged
gautamdsheth merged 2 commits intopnp:devfrom Aug 9, 2024
Merged
Conversation
Handle $ErrorActionPreference in the same way as -ErrorAction cmdlet parameter is handled
Collaborator
|
Thanks @jackpoz , great addition, much appreciated ! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Type
Related Issues?
No related issues
What is in this Pull Request ?
Handle
$ErrorActionPreferenceglobal PowerShell variable in the same way as-ErrorActioncmdlet parameter is handled when throwing exceptions. Documentation about$ErrorActionPreferenceat https://learn.microsoft.com/en-us/powershell/module/microsoft.powershell.core/about/about_preference_variables?view=powershell-7.4#erroractionpreference$ErrorActionPreference = 'Stop'can be put on top of scripts and it will change the behavior of ErrorAction for the whole PowerShell session.Behavior before this change. Notice how the callstack shows the generic
PnPConnectedCmdlet.ProcessRecord()method:Behavior after this change. Notice how
Get-PnPExceptionshows the full callstack includingGetList.ExecuteCmdlet():-ErrorAction:Stopcmdlet parameter still works:-ErrorAction:Stopalso takes precedence over$ErrorActionPreference: