new cmdlet for Add-PnPTenantRestrictedSearchAllowedList#3993
Merged
KoenZomers merged 9 commits intopnp:devfrom Sep 10, 2024
reshmee011:rssaddsites
Merged
new cmdlet for Add-PnPTenantRestrictedSearchAllowedList#3993KoenZomers merged 9 commits intopnp:devfrom reshmee011:rssaddsites
KoenZomers merged 9 commits intopnp:devfrom
reshmee011:rssaddsites
Conversation
Collaborator
|
Thanks @reshmee011 . It feels like a paramset would be a better fit here as opposed to using Dynamic Parameters. Would you agree or is there a specific reason you chose to go with this option? |
Collaborator
Author
|
@KoenZomers : Hello, it makes more sense to use paramset to be consistent and easier to maintain in the future. I will refactor the code. |
Collaborator
|
Thanks @reshmee011 . Please share when it's ready for review. |
Collaborator
Author
|
@KoenZomers : I have updated the cmdlet to use parameter set, thanks very much for the review. |
Collaborator
|
Thanks @reshmee011 ! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Type
What is in this Pull Request ?
Files to support new cmdlet for Add-PnPTenantRestrictedSearchAllowedList
documentation\Add-PnPTenantRestrictedSearchAllowedList.md
src\Commands\Admin\AddTenantRestrictedSearchAllowedList.cs