Skip to content

[FileVersion] Add and update batch delete cmdlets#3828

Merged
KoenZomers merged 7 commits intopnp:devfrom
msjennywu:BatchDeleteCmdletUpdate
Apr 8, 2024
Merged

[FileVersion] Add and update batch delete cmdlets#3828
KoenZomers merged 7 commits intopnp:devfrom
msjennywu:BatchDeleteCmdletUpdate

Conversation

@msjennywu
Copy link
Contributor

@msjennywu msjennywu commented Mar 13, 2024 •
edited
Loading

Before creating a pull request, make sure that you have read the contribution file located at

https://github.com/pnp/powerShell/blob/dev/CONTRIBUTING.md

Type

  • Bug Fix
  • New Feature
  • Sample

What is in this Pull Request ?

  1. Updated existing commands "New-PnPSiteFileVersionBatchDeleteJob" and "New-PnPLibraryFileVersionBatchDeleteJob" with new batch delete mode
  2. Added new commands for getting progress "Get-PnPSiteFileVersionBatchDeleteJobProgress" and "Get-PnPLibraryFileVersionBatchDeleteJobProgress"
  3. Added or updated related documentations

Test scenarios

  1. Create DeleteOlderThanDays workitem on site
    New-PnPSiteFileVersionBatchDeleteJob -DeleteBeforeDays 40
    Get-PnPSiteFileVersionBatchDeleteJobProgress

  2. Create CountLimits workitem on site
    New-PnPSiteFileVersionBatchDeleteJob -MajorVersionLimit 10 -MajorWithMinorVersionsLimit 10
    Get-PnPSiteFileVersionBatchDeleteJobProgress

  3. Create AutomaticTrim workitem on site
    New-PnPSiteFileVersionBatchDeleteJob -Automatic
    Get-PnPSiteFileVersionBatchDeleteJobProgress

  4. Remove workitem on site
    Remove-PnPSiteFileVersionBatchDeleteJob
    Get-PnPSiteFileVersionBatchDeleteJobProgress

  5. Create DeleteOlderThanDays workitem on library
    New-PnPLibraryFileVersionBatchDeleteJob -Identity "jsite1lib1" -DeleteBeforeDays 200
    Get-PnPLibraryFileVersionBatchDeleteJobProgress -Identity "jsite1lib1"

  6. Create CountLimits workitem on library
    New-PnPLibraryFileVersionBatchDeleteJob -Identity "jsite1lib1" -MajorVersionLimit 10 -MajorWithMinorVersionsLimit 10
    Get-PnPLibraryFileVersionBatchDeleteJobProgress -Identity "jsite1lib1"

  7. Create AutomaticTrim workitem on library
    New-PnPLibraryFileVersionBatchDeleteJob -Identity "jsite1lib1" -Automatic
    Get-PnPLibraryFileVersionBatchDeleteJobProgress -Identity "jsite1lib1"

  8. Remove workitem on library
    Remove-PnPLibraryFileVersionBatchDeleteJob -Identity "jsite1lib1"
    Get-PnPLibraryFileVersionBatchDeleteJobProgress -Identity "jsite1lib1"

Test results

  1. Site commands
image image image image
  1. Library commands
image image image image

@gautamdsheth
Copy link
Collaborator

gautamdsheth commented Mar 25, 2024

Hi @KoenZomers , @msjennywu - the cmdlet names are too long. We need to trim it.
How about New-PnPFileVersionBatchDeleteJob , a single cmdlet which does the job for both site and document library. We separate them by Parameter sets ? Same goes for other cmdlets as well which work on this.

New-PnPFileVersionBatchDeleteJob, Get-PnPFileVersionBatchDeleteStatus, Remove-PnPFileVersionBatchDeleteJob etc. is what I am proposing. The existing names don't make sense to me and will also confuse users as well I think. In the new names that I propose, we add additional parameters like -Site or -List or -Library .

Thoughts ?

@KoenZomers
Copy link
Collaborator

KoenZomers commented Apr 8, 2024

Cmdlets renamed as discussed through Teams. Ready to merge.

@KoenZomers KoenZomers merged commit ea27043 into pnp:dev Apr 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@msjennywu @gautamdsheth @KoenZomers