fix: some properties of ExtractConfiguration are not used#3715
Conversation
Some properties of ProvisioningTemplateCreationInformation were always set, regardless of them being explicitly set in the Cmdlet, or not. Thus, those properties could not be set by using an ExtractConfiguration.
|
Thanks @nils-a for your contribution. Can you please edit this PR and allow us to update your PR? We need it to include the changelog entry. |
|
@KoenZomers This is a trap I always fall into. While editing of this PR is allowed, it does not work since you have no permissions on my fork. This is a "feature" of GitHub, when forks are created in an organization... I have given you write permissions on my fork, so you should now be able to push into it. |
|
Thanks @nils-a. Not sure what it is, but it still cannot interact with your PR branch. Typically only just leaving the default checkbox checked when creating your PR should be enough. No need to share entire repositories: 
For now let's not waste any more time on this. I have taken your changes and created a new PR #3741 through which I will merge them. Thanks for your efforts! |
|
Merged through #3741 |
Type
Related Issues?
fixes pnp/pnpframework#953
What is in this Pull Request ?
Some properties of
ProvisioningTemplateCreationInformationwere always set, regardless of them being explicitly set in the Cmdlet, or not.Thus, those properties could not be set by using an
ExtractConfiguration.