Fix: #3621 - AddNavigationNode - Search in sub nodes for id#3625
Merged
gautamdsheth merged 2 commits intopnp:devfrom Jan 9, 2024
Merged
Fix: #3621 - AddNavigationNode - Search in sub nodes for id#3625gautamdsheth merged 2 commits intopnp:devfrom
gautamdsheth merged 2 commits intopnp:devfrom
Conversation
Collaborator
|
@JuergenRB - is this ready ? Have you tested the code ? |
5e3bb15 to
f7d932d
Compare
Contributor
Author
|
@gautamdsheth - Yes, the change is finished and tested |
Collaborator
|
Thanks @JuergenRB , good catch, much appreciated the fix for the issue !! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Type
Related Issues?
Issue #3621
What is in this Pull Request ?
Within the AddNavigationNode command:
NavigationNode property Nodes now also contains NavigationNodes instead of objects.
To find a node by ID, not only the first list but also all child nodes are searched.