Fix #3236: Directly operate on List#3244
Merged
gautamdsheth merged 1 commit intopnp:devfrom Jul 5, 2023
nils-a-forks:feature/GH-3236
Merged
Fix #3236: Directly operate on List#3244gautamdsheth merged 1 commit intopnp:devfrom nils-a-forks:feature/GH-3236
gautamdsheth merged 1 commit intopnp:devfrom
nils-a-forks:feature/GH-3236
Conversation
The old code retrieves the List object, to then call a helper and pass the title of the list. The helper, in turn, retrieves the list (again) by its title to then add the ContentType. Since the method already has a reference to the list, we can forgo the helper.
Collaborator
|
Ahh , my bad |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before creating a pull request, make sure that you have read the contribution file located at
https://github.com/pnp/powerShell/blob/dev/CONTRIBUTING.md
Type
Related Issues?
Fixes #3236
What is in this Pull Request ?
The old code retrieved the List object, to then call a helper and pass the title of the list.
The helper, in turn, retrieves the list (again) by its title to then add the ContentType.
Since the method already has a reference to the list, we can forgo the helper.
Summary
copilot:summary
Details
copilot:walkthrough