Change Set-PnPWebhookSubscription to use the same defualt expiration date as Add-PnPWebhookSubsription#3106
Merged
gautamdsheth merged 2 commits intopnp:devfrom May 17, 2023
Conversation
Collaborator
|
Good catch, thanks @reusto !! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…kSubscription
Before creating a pull request, make sure that you have read the contribution file located at
https://github.com/pnp/powerShell/blob/dev/CONTRIBUTING.md
Type
Related Issues?
What is in this Pull Request ?
Update to Set-PnPWebhookSubscription to use the same default expiration data as Add-PnPWebhookSubscription.
This resolves a potential issue where 6 months - 72 hours > 180 days which would return an error from the API. (see: https://learn.microsoft.com/en-us/sharepoint/dev/apis/webhooks/overview-sharepoint-webhooks#expiration)
Summary
copilot:summary
Details
copilot:walkthrough