Adding VivaConnectionsDefaultStart option to SetHomeSite#2779
Adding VivaConnectionsDefaultStart option to SetHomeSite#2779gautamdsheth merged 11 commits intopnp:devfrom reshmee011:dev
Conversation
|
Awesome stuff @reshmee011 , just 2 comments :)
Also, @anoopt , dont work on this now 🤣😭 |
|
@gautamdsheth : thanks for the prompt review, I need to remember about updating docs in the future. @anoopt : hope you have not worked on it yet. @gautamdsheth : for any new features, shall I raise it as an issue first before I start working on it? |
|
Hi @reshmee011 , any reason you changed the parameter to bool ? I liked the SwitchParameter :) Maybe we can keep using the SwitchParameter ? No, no need to open an issue for this. It was just something we discussed while chatting about something totally different ! |
|
@gautamdsheth , bool will allow to pass $true or $false to toggle on and off the viva experience to the Home Site, switch parameter does not give that ability. |
|
We can set the value when using SwitchParameter 😊 Like this: You can check this example: https://pnp.github.io/powershell/cmdlets/Enable-PnPPowerShellTelemetry.html We are using |
|
@gautamdsheth : Awesome, thanks for the example how to use the switchparameter to turn on and off. I did not think about it. Happy to keep it as switch parameter. Shall I make updates to the code and docs to revert the VivaConnectionsDefaultStart to switch parameter. ? |
|
Yes please 😊 |
|
@gautamdsheth : I have reverted the parameter to be switch parameter and amended the get-pnphomesite to return its value with an additional parameter. |
|
Thank you, merged it ! |
Before creating a pull request, make sure that you have read the contribution file located at
https://github.com/pnp/powerShell/blob/dev/CONTRIBUTING.md
Type
What is in this Pull Request ?
Adding ability to set VivaConnectionsDefaultStart