Skip to content

Added Custom Padding on Alert Description StackView#60

Closed
mdflores wants to merge 1 commit intopmusolino:masterfrom
mdflores:master
Closed

Added Custom Padding on Alert Description StackView#60
mdflores wants to merge 1 commit intopmusolino:masterfrom
mdflores:master

Conversation

@mdflores
Copy link
Copy Markdown

Alert Description is too close to the AlertController's ContentView when Alert Description is customized not to have a center alignment.

Changes for this PR:
Added Custom Padding on Alert Description StackView
Updated Sample Project

@pasevin
Copy link
Copy Markdown
Contributor

pasevin commented Apr 9, 2018

Great addition to customization.

@pmusolino
Copy link
Copy Markdown
Owner

Thanks for this PR, I check it out during the weekend.

@pmusolino
Copy link
Copy Markdown
Owner

pmusolino commented Apr 11, 2018

@mdflores I reviewed your PR, but there are some problems.

First of all, the name for the two constraints is ambiguous, because inside the alert there are two UIStackViews, one for title and description, and one for the buttons (PMAlertAction).
You named the constraints alertStackViewLeadingConstraint and alertStackViewTrailingConstraint but there is another constraint called alertStackViewHeightConstraint that is a reference to the 2° stack view. Then, try to find a name to disambiguate.

The second point: you implemented this feature, but is interesting to implement the same on the second stack view (alertActionStackView).

Please, integrate this and I can approve your PR.
Thanks

-Paolo

@pasevin
Copy link
Copy Markdown
Contributor

pasevin commented Apr 14, 2018

I've expanded on this pull request and addressed your comments @pmusolino #61

@pmusolino
Copy link
Copy Markdown
Owner

Closed in favor of #61

@pmusolino pmusolino closed this Apr 22, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants