examples: remove call to exit from thread function#5451
Merged
hzhou merged 1 commit intopmodels:mainfrom Jul 28, 2021
Merged
Conversation
raffenet
approved these changes
Jul 26, 2021
Contributor
raffenet
left a comment
There was a problem hiding this comment.
Removing these is an improvement. MPI_Abort or pthread_exit would also be acceptable. As an aside, this example looks incorrect for MPI_THREAD_SERIALIZED thread level.
Contributor
Author
Yeah. I think the mutex lock should be inside the condition of |
The exit call in the thread functions have potential thread racing issues and may leave another process hanging. I think it is unnecessary for the example and may cause more confusion.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request Description
The exit call in the thread functions have potential thread racing
issues and may leave another process hanging. I think it is unnecessary
for the example and may cause more confusion.
Fixes #5444
[skip warnings]
Author Checklist
Particularly focus on why, not what. Reference background, issues, test failures, xfail entries, etc.
Commits are self-contained and do not do two things at once.
Commit message is of the form:
module: short descriptionCommit message explains what's in the commit.
Whitespace checker. Warnings test. Additional tests via comments.
For non-Argonne authors, check contribution agreement.
If necessary, request an explicit comment from your companies PR approval manager.