Skip to content

fix(devtools): Avoid inferring action type when explicit action name is provided#3147

Merged
dai-shi merged 2 commits intopmndrs:mainfrom
vchirikov:devtools-fix
Jun 23, 2025
Merged

fix(devtools): Avoid inferring action type when explicit action name is provided#3147
dai-shi merged 2 commits intopmndrs:mainfrom
vchirikov:devtools-fix

Conversation

@vchirikov
Copy link
Copy Markdown
Contributor

Summary

#2987 Added call findCallerName() which tries to infer action name from error's callstack even when user explicitly provided action name (nameOrAction or anonymousActionType). I think it's much better to call findCallerName ONLY if user didn't provide anything we can use.

Check List

  • pnpm run fix for formatting and linting code and docs

@vercel
Copy link
Copy Markdown

vercel bot commented Jun 7, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
zustand-demo ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 23, 2025 3:07am

@codesandbox-ci
Copy link
Copy Markdown

codesandbox-ci bot commented Jun 7, 2025

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

@pkg-pr-new
Copy link
Copy Markdown

pkg-pr-new bot commented Jun 7, 2025

demostarter

npm i https://pkg.pr.new/zustand@3147

commit: 2a3f3ad

Copy link
Copy Markdown
Member

@dai-shi dai-shi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dai-shi dai-shi added this to the v5.0.6 milestone Jun 8, 2025
@IDisposable
Copy link
Copy Markdown

I just came here to make the exact same comment. :shipit:

@dai-shi dai-shi changed the title Avoid inferring action type when explicit action name is provided fix(devtools): Avoid inferring action type when explicit action name is provided Jun 23, 2025
@dai-shi dai-shi merged commit ca08a5e into pmndrs:main Jun 23, 2025
31 checks passed
@vchirikov vchirikov deleted the devtools-fix branch June 23, 2025 16:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants