refactor: remove unnecessary type assertion in createJSONStorage#3113
Merged
dai-shi merged 2 commits intopmndrs:mainfrom May 21, 2025
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. |
dai-shi
approved these changes
May 8, 2025
Member
dai-shi
left a comment
There was a problem hiding this comment.
It looks good as CI passes. (we dropped some old TS versions in v5.)
Contributor
Author
|
Thank you for reviewing! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related Bug Reports or Discussions
Fixes #
Summary
For readability, remove unnecessary type assertion in
createJSONStorage().call
getStorage()in 37 line ensure thatstoragetype(StateStorage).Thank you :)
Check List
pnpm run fixfor formatting and linting code and docs