The latest updates on your projects. Learn more about Vercel for Git ↗︎

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

demo • starter

npm i https://pkg.pr.new/zustand@3111

commit: d48fb3d

This sounds reasonable to me. Can anyone give a deep review?

@dbritto-dev What do you think?

@dai-shi LGTM but up to you

I had a closer look, but it looks good. One concern, which is not this PR's fault, is that the code around connection info isn't very readable. It took me while to get it.

We would like to refactor in the future, and for that, can you add a test that depends on removeStoreFromTrackedConnections?

@dai-shi
I'd like to test removeStoreFromTrackedConnections by verifying that the store is actually removed from the trackedConnections Map. However, since trackedConnections is a private variable within the module, I'm not sure how to properly test this.

Do you have any suggestions for how to test this functionality properly?
Thanks for your guidance!

Actually, I don't.
What would happen is memory leaks, but testing memory leaks isn't very straightforward.
Testing internal variables isn't nice either. (It's only testing implementation details.)

Actually, I have an idea. If we fail to remove from tracked connections,
after cleanup, when we try another connection, it will fail to connect again.
So, we should be able to test it from outside. Somewhat different, but kind of.

Actually, I don't. What would happen is memory leaks, but testing memory leaks isn't very straightforward. Testing internal variables isn't nice either. (It's only testing implementation details.)

Actually, I have an idea. If we fail to remove from tracked connections, after cleanup, when we try another connection, it will fail to connect again. So, we should be able to test it from outside. Somewhat different, but kind of.

Here's the updated patch: 383d932. Let me know if anything needs to be adjusted!

@dai-shi I'll take care of docs