Skip to content

refactor(traditional): remove duplicated ExtractState type declaration#2982

Merged
dai-shi merged 2 commits intopmndrs:mainfrom
shinhyogeun:fix/extract-state-duplication
May 1, 2025
Merged

refactor(traditional): remove duplicated ExtractState type declaration#2982
dai-shi merged 2 commits intopmndrs:mainfrom
shinhyogeun:fix/extract-state-duplication

Conversation

@shinhyogeun
Copy link
Copy Markdown
Contributor

Related Bug Reports or Discussions

Fixes #

Summary

Regarding the work in the following PR, I agree with the location of ExtractState type, but this PR removes unnecessary redundant type declarations.

Check List

  • pnpm run fix:format for formatting code and docs

@vercel
Copy link
Copy Markdown

vercel Bot commented Jan 27, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
zustand-demo ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 1, 2025 2:39am

@codesandbox-ci
Copy link
Copy Markdown

codesandbox-ci Bot commented Jan 27, 2025

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

@pkg-pr-new
Copy link
Copy Markdown

pkg-pr-new Bot commented Jan 27, 2025

demostarter

npm i https://pkg.pr.new/zustand@2982

commit: cad6f44

Copy link
Copy Markdown
Member

@dai-shi dai-shi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. I'll merge this when we prepare the next release.

@dai-shi dai-shi changed the title remove duplicated ExtractState type declaration refactor(traditional): remove duplicated ExtractState type declaration Jan 27, 2025
@dai-shi dai-shi added this to the v5.0.4 milestone Apr 28, 2025
@dai-shi dai-shi merged commit c72ac92 into pmndrs:main May 1, 2025
27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants