Skip to content

Fix/follow ref in snapshot#65

Merged
dai-shi merged 4 commits into
masterfrom
fix/follow-ref-in-snapshot
Jan 15, 2021
Merged

Fix/follow ref in snapshot#65
dai-shi merged 4 commits into
masterfrom
fix/follow-ref-in-snapshot

Conversation

@dai-shi

@dai-shi dai-shi commented Jan 14, 2021

Copy link
Copy Markdown
Member

Follow-up #62

It turns out that the "Caveat 1" in #62 can be a real issue, not quite surprisingly...

So, this fixes the behavior and the Caveat 1 is gone.

The issue is reported in discord like this:

Is ref supposed to make it possible to store arbitrary React components inside of valtio state? I'm running into an issue when storing certain components
https://codesandbox.io/s/qo9nh

@codesandbox-ci

codesandbox-ci Bot commented Jan 14, 2021

Copy link
Copy Markdown

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit ceea29b:

Sandbox Source
React Configuration
React Typescript Configuration
valtio-component-ref PR

@dai-shi dai-shi merged commit e970625 into master Jan 15, 2021
@dai-shi dai-shi deleted the fix/follow-ref-in-snapshot branch January 15, 2021 12:25
@dai-shi dai-shi mentioned this pull request Jan 15, 2021
@dai-shi

dai-shi commented Jan 15, 2021

Copy link
Copy Markdown
Member Author

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant