Allow v5 of webpack-dev-server as peer dependency#836
Closed
mxdvl wants to merge 6 commits intopmmmwh:mainfrom
Closed
Allow v5 of webpack-dev-server as peer dependency#836mxdvl wants to merge 6 commits intopmmmwh:mainfrom
webpack-dev-server as peer dependency#836mxdvl wants to merge 6 commits intopmmmwh:mainfrom
Conversation
The http & https options are not used internally https://github.com/webpack/webpack-dev-server/blob/master/migration-v5.md
Review or Edit in CodeSandboxOpen the branch in Web Editor • VS Code • Insiders |
Owner
I think we should, just to make sure tests pass. If that can be done I'm happy to cut this release first then work towards moving completely over to v5 👍🏻 |
Owner
this ensures the test pass locally, but does not address how to keep tests running against v4
in CI, we have incompatible packes, but that is acceptable as we are testing different Node versions againt the library
Author
|
@pmmmwh I’ve tried and failed to make CI pass: |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Release notes v5.0.0 along with the migration guide.
webpackandwebpack-cliof the consumer are not a concern of this packagehttp&httpsoptions are not used internallyShould we also bump the local dev dependency on
webpack-dev-serverto v5?