Do not override sockProtocol from config#835
Merged
pmmmwh merged 2 commits intopmmmwh:mainfrom Apr 25, 2024
darkexone:main
Merged
Do not override sockProtocol from config#835pmmmwh merged 2 commits intopmmmwh:mainfrom darkexone:main
pmmmwh merged 2 commits intopmmmwh:mainfrom
darkexone:main
Conversation
Review or Edit in CodeSandboxOpen the branch in Web Editor • VS Code • Insiders |
Owner
With the later versions of WDS v4 and WDS v5 we can actually re-use the "created" server so we no-longer need to parse any of their config. It'll probably come in the next version though. |
pmmmwh
approved these changes
Apr 25, 2024
Owner
|
Thanks for the PR! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hey, I came across a case where
sockProtocolis incorrectly overwritten. My application does not use https, but is served through a proxy that uses https. I have https disabled in the webpack configuration, but the protocol read from the window is https. I tried passing thesockProtocolparameter, but found that wss is used all the time, resulting in itegration with overlay not working. I believe that the config passed by the developer (aresourceQuery) should take priority over a failsafe configuration.A better idea would be to make a mechanism for reading the
webSocketURLfrom the Webpack configuration (as suggested in #742 and #728), because this fix will help only for part of the problems with connecting to the wrong sockets. Until this mechanism is implemented, we should prefer the plugin configuration over the values read from the path.