Skip to content

Updates loader-utils to 3.2.1 due to Security Vulnerability#834

Closed
boroth wants to merge 2 commits intopmmmwh:mainfrom
LeadingReach:update-loader-utils
Closed

Updates loader-utils to 3.2.1 due to Security Vulnerability#834
boroth wants to merge 2 commits intopmmmwh:mainfrom
LeadingReach:update-loader-utils

Conversation

@boroth
Copy link
Copy Markdown

@boroth boroth commented Apr 10, 2024

Been resolving some Dependabot alerts in another repo, and ran into an issue with react-refresh-webpack-plugin needing to be updated to the newer version of loader-utils. This just updates the loader-utils package, but I'm also open to doing some additional yarn updating/auditing if people are interested in that.

Tests seem to be passing, just need to run a build and see if it's all good to go 👍🏾

@codesandbox
Copy link
Copy Markdown

codesandbox bot commented Apr 10, 2024

Review or Edit in CodeSandbox

Open the branch in Web EditorVS CodeInsiders

Open Preview

@boroth
Copy link
Copy Markdown
Author

boroth commented Apr 10, 2024

I guess this fix may only work on Webpack 5, not sure what the standard way of handling that is in this project.

I wouldn't be opposed to trying to get react-refresh-webpack-plugin to a 1.0.0 version with Node 16+ and Webpack 5+ if y'all are up for it.

"find-up": "^5.0.0",
"html-entities": "^2.1.0",
"loader-utils": "^2.0.4",
"loader-utils": "^3.2.1",
Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we still consume loader-utils directly? If not I'm leaning towards removing this as a dependency to let downstream decide on what version is best for them.

@pmmmwh
Copy link
Copy Markdown
Owner

pmmmwh commented Apr 25, 2024

I guess this fix may only work on Webpack 5, not sure what the standard way of handling that is in this project.

I wouldn't be opposed to trying to get react-refresh-webpack-plugin to a 1.0.0 version with Node 16+ and Webpack 5+ if y'all are up for it.

I'll look a bit into if it's possible to have both supported and resolve the vulnerability. In any case I don't think we're really using the code path that is reported, but it's nonetheless good to be on a version where this doesn't warn.

@pmmmwh
Copy link
Copy Markdown
Owner

pmmmwh commented Jun 2, 2024

Will be fixed in v0.6.0.

@pmmmwh pmmmwh closed this Jun 2, 2024
@pmmmwh pmmmwh mentioned this pull request Jun 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants