Closed
Conversation
This was referenced Feb 10, 2023
Closed
Contributor
Author
|
Looks like this little change broke most of the conformance tests. Looking into it. |
7 tasks
Contributor
Author
|
@pmmmwh 👋 Any thoughts on this? If this doesn't feel like the right solution I'm happy to submit a separate PR to help address the issue. Thanks! |
pmmmwh
reviewed
Apr 12, 2023
Comment on lines
+41
to
+46
| // if matchResource is set it means another loader is | ||
| // dynamically generating a module so let's look into moduleData.request | ||
| // to give users the opportunity to exclude them from instrumentation | ||
| if (moduleData.matchResource && !match(moduleData.request)) { | ||
| return moduleData; | ||
| } |
Owner
There was a problem hiding this comment.
I think we can collapse this into the big if statement above?
Contributor
Author
There was a problem hiding this comment.
IMO readability is easier by doing it outside since we only want to match against moduleData.request if moduleData.matchResource is set but maybe my brain is just not working well right now lol
Owner
There was a problem hiding this comment.
I guess another way to do this is to break down the if statement and do a bunch of early returns 🤔
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
matching against
moduleData.requestwould allow folks to exclude virtual modules generated by other loaders (like linaria). For my use-case I can now do this:To prevent react-refresh from being injected into CSS virtual modules (generated by linaria).
See #245 (comment) for more context.