Reviewed 4 of 4 files at r1, all commit messages.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @grom72 and @janekmi)

src/libpmem2/map.c line 2 at r1 (raw file):

// SPDX-License-Identifier: BSD-3-Clause
/* Copyright 2019-2023, Intel Corporation */

Not needed.

src/libpmem2/map_posix.c line 624 at r1 (raw file):

				goto err_register_map;
		}

Please remove empty line

Reviewed 4 of 4 files at r1, all commit messages.
Reviewable status: all files reviewed, 5 unresolved discussions (waiting on @grom72)

src/libpmem2/map_posix.c line 629 at r1 (raw file):

	/*
	 * Always delete automatically created mover.
	 */

I know it is a discovery for this code base. Since probably till now nobody knew when and what should be released or not. But now it is obvious from the code. Hence, this comment is redundant.

src/libpmem2/mover.c line 188 at r1 (raw file):

		return ret;

	LOG(3, "map %p, vdm %p", map, dms);

It looks atypical. Is it intentional?

src/libpmem2/mover.c line 213 at r1 (raw file):
It seems we tend to print here names of arguments.

LOG(3, "dms %p", dms);

Reviewable status: 1 of 4 files reviewed, 5 unresolved discussions (waiting on @janekmi and @osalyk)

src/libpmem2/map_posix.c line 624 at r1 (raw file):

Done.

src/libpmem2/map_posix.c line 629 at r1 (raw file):

Done.

src/libpmem2/mover.c line 188 at r1 (raw file):

Yes, to see the address of allocated dms -> see mover_delete()

src/libpmem2/mover.c line 213 at r1 (raw file):

Done.

src/libpmem2/map.c line 2 at r1 (raw file):

Done.

Reviewed 1 of 4 files at r1, 3 of 3 files at r2.
Reviewable status: all files reviewed (commit messages unreviewed), 5 unresolved discussions (waiting on @janekmi and @osalyk)

Reviewed 3 of 3 files at r2, all commit messages.
Reviewable status: all files reviewed, 3 unresolved discussions (waiting on @janekmi)

Reviewed 1 of 1 files at r3, all commit messages.
Reviewable status: all files reviewed, 3 unresolved discussions (waiting on @janekmi)

Reviewed 3 of 3 files at r2, 1 of 1 files at r4, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @grom72)

Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @grom72)

src/libpmem2/mover.c line 188 at r4 (raw file):

		return ret;

src/libpmem2/mover.c:188: ERROR duplicated empty line

Reviewed 2 of 2 files at r5, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @grom72)

Reviewed 2 of 2 files at r6, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @grom72)

Reviewed 1 of 2 files at r5.
Reviewable status: 5 of 6 files reviewed, all discussions resolved (waiting on @janekmi)