Add scala syntax highlighter#26
Merged
Merged
Conversation
This reverts commit 998582c1fcd8f78f3165ca1609312f84b7c1f116.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This experiments with the possibility of writing a highlighter with a flex lexer. I used a lexer from the intellij-scala plugin, simplified it a lot but kept the essential parts, including the ability to lex string interpolations of arbitrary depth. The same lexer may be used with minimal modifications to lex kotlin code, if at some point it's fully supported by PMD.
For example:
This does not require bumping the version of pmd-core, it's still compatible with 6.12.0.