[java] AvoidSynchronizedStatement: Improve rule doc#6657
Merged
Conversation
Contributor
|
Compared to main: (comment created at 2026-05-19 18:23:41+00:00 for 3499944) |
UncleOwen
requested changes
May 14, 2026
UncleOwen
left a comment
Member
There was a problem hiding this comment.
New description looks good!
zbynek
reviewed
May 14, 2026
Refs pmd#5175 (comment) While it's not wrong to put "lock.lock()" inside the try, the best practice documented in https://docs.oracle.com/en/java/javase/25/docs/api/java.base/java/util/concurrent/locks/ReentrantLock.html puts it directly before the try. Also added an explicit example of tryLock() usage.
a96aaec to
3499944
Compare
Member
Author
|
Thanks for the reviews! |
zbynek
approved these changes
May 19, 2026
UncleOwen
approved these changes
May 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe the PR
Refs #5175 (comment)
While it's not wrong to put "lock.lock()" inside the try, the best practice documented in https://docs.oracle.com/en/java/javase/25/docs/api/java.base/java/util/concurrent/locks/ReentrantLock.html puts it directly before the try.
Also added an explicit example of tryLock() usage.
Related issues
Ready?
./mvnw clean verifypasses (checked automatically by github actions)