Describe the PR

This PR fixes a false positive in the UnusedLocalVariable rule where pattern variables declared via instanceof are incorrectly reported as unused when they appear inside an if statement that is the direct child of a for-each loop without braces.

The Root Cause

In SymbolTableResolver, the ASTForeachStatement was previously handled by the outer MyVisitor class. When a for-each loop omits braces, its body (e.g., an ASTIfStatement) is visited using the outer visitor's context. However, the logic for extracting and pushing pattern variable bindings (flow-sensitive scoping) is implemented only within the inner StatementVisitor.

Consequently, the pattern variable s in if (o instanceof String s) was never registered in the symbol table when nested directly under a foreach because the IfStatement was visited by MyVisitor, which lacks the pattern-matching awareness of StatementVisitor.

The Fix

I moved the visit(ASTForeachStatement) logic from MyVisitor to StatementVisitor. This ensures that the loop body is always visited with a visitor capable of handling pattern bindings, aligning the behavior with how while and standard for loops are already implemented in PMD 7.

Related issues

• Fix [java] UnusedLocalVariable: False positive for pattern variable in for-each without braces #6328

Ready?

• Added unit tests for fixed bug/feature
• Passing all unit tests
• Complete build ./mvnw clean verify passes (checked automatically by github actions)
• Added (in-code) documentation (if needed)