apply pmd-eclipse-code-formatter.xml via spotless#5925
Conversation
|
[INFO] --- checkstyle:3.6.0:check (checkstyle-check) @ pmd-core --- |
|
have i choose the wrong config or is it like the imports just outdated? |
pmd-eclipse-code-formatter.xml via spotless
pmd-eclipse-code-formatter.xml via spotlesspmd-eclipse-code-formatter.xml via spotless
e9dc6f8 to
499a71e
Compare
|
kindly request your feedback. @oowekyala plugin support as well:
|
|
just need to run apply goal then its good to go, fully applying your convention hardly configured twice but not fully lived twice therefore only one could remain until you ether merge them or go with the working one which is eclipse controlled by spot. |
plz try to consider. its still a topic non a improvement but maybe broken config. thats two different kind. |
have you tried to confirm this? Step by step:
|
|
done. I did not configure idea, but the maven plugin. Both will refer to some eclipse jar applying the format. The only issue could be a version diff, but this is very unlikely according to the 7 years its not been updated, just like the config before. |
This comment was marked as resolved.
This comment was marked as resolved.
|
Lets start with real errors and then fix the broken format. |
Yes the whole PR is just about this. See what two different eclipse parsers do with the same config: |
the PR is idempotent.
This setup is not. |
if you want i can make another one with this plugin: Assuming you have the IDE ready. Can you (re)format the whole project without any changed? This would be the expectation and the status quo after plugin installation. |


apply
pmd-eclipse-code-formatter.xmlviaspotlessas the convention are now fully taken care by spot, the broken harmony on the config between the imposed eclipse format and enrolled check config require the need for action.
This is one variant improving the dev exp.
following the contribution guide this again seems to be outdated, at least when applying the config the code changes and checkstyle violates:
Related issues
Ready?
./mvnw clean verifypasses (checked automatically by github actions)