[java] Fix crash when parsing class for anonymous class #5588
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sample that would cause the crash is
enum Foo {
A { }
}
and parsing class Foo$1.class. The simple name was not being populated.
|
Compared to main: |
41cac7c to
e8e771d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe the PR
Parsing the class file of an anonymous class was not populating the simple name, causing an NPE. I'm not sure why an anonymous class was parsed at all, but this crash occurred when analysing JDK sources.
Related issues
Ready?
./mvnw clean verifypasses (checked automatically by github actions)